Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: third_party/WebKit/Source/core/frame/Window.idl

Issue 2855263004: Throw in window.open() when an invalid URL is being passed (Closed)
Patch Set: updates Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
3 * Copyright (C) 2011 Google Inc. All rights reserved. 3 * Copyright (C) 2011 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 56
57 // other browsing contexts 57 // other browsing contexts
58 [Replaceable, CrossOrigin] readonly attribute Window frames; 58 [Replaceable, CrossOrigin] readonly attribute Window frames;
59 [Replaceable, CrossOrigin] readonly attribute unsigned long length; 59 [Replaceable, CrossOrigin] readonly attribute unsigned long length;
60 [Unforgeable, CrossOrigin] readonly attribute Window? top; 60 [Unforgeable, CrossOrigin] readonly attribute Window? top;
61 // FIXME: opener should be of type any. 61 // FIXME: opener should be of type any.
62 [CrossOrigin, Custom=Setter] attribute Window opener; 62 [CrossOrigin, Custom=Setter] attribute Window opener;
63 [Replaceable, CrossOrigin] readonly attribute Window? parent; 63 [Replaceable, CrossOrigin] readonly attribute Window? parent;
64 [CheckSecurity=ReturnValue, Custom=Getter] readonly attribute Element? frame Element; 64 [CheckSecurity=ReturnValue, Custom=Getter] readonly attribute Element? frame Element;
65 // FIXME: open() should have 4 optional arguments with defaults. 65 // FIXME: open() should have 4 optional arguments with defaults.
66 [Custom] Window? open(DOMString url, DOMString target, optional DOMString fe atures); 66 [Custom, RaisesException] Window? open(DOMString url, DOMString target, opti onal DOMString features);
foolip 2017/05/05 11:21:29 FYI, I wondered if returning null is still possibl
jochen (gone - plz use gerrit) 2017/05/05 11:25:51 correct, that should return null. Also note that t
foolip 2017/05/05 11:28:55 Yeah, just verifying since sometimes the exception
67 67
68 // indexed properties 68 // indexed properties
69 // https://html.spec.whatwg.org/C/browsers.html#windowproxy-getownproperty 69 // https://html.spec.whatwg.org/C/browsers.html#windowproxy-getownproperty
70 [NotEnumerable, CrossOrigin] getter Window (unsigned long index); 70 [NotEnumerable, CrossOrigin] getter Window (unsigned long index);
71 // https://html.spec.whatwg.org/C/browsers.html#windowproxy-defineownpropert y 71 // https://html.spec.whatwg.org/C/browsers.html#windowproxy-defineownpropert y
72 setter void (unsigned long index, any value); 72 setter void (unsigned long index, any value);
73 73
74 // named properties 74 // named properties
75 [Custom, NotEnumerable, CrossOrigin] getter object (DOMString name); 75 [Custom, NotEnumerable, CrossOrigin] getter object (DOMString name);
76 76
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
218 // FIXME: make this typedef accurate once enough of https://crbug.com/240176 218 // FIXME: make this typedef accurate once enough of https://crbug.com/240176
219 // is in place. 219 // is in place.
220 // FIXME: consider putting this typedef in an .idl file containing spec-wide 220 // FIXME: consider putting this typedef in an .idl file containing spec-wide
221 // utility type definitions. 221 // utility type definitions.
222 typedef MessagePort Transferable; 222 typedef MessagePort Transferable;
223 223
224 Window implements GlobalEventHandlers; 224 Window implements GlobalEventHandlers;
225 Window implements WindowBase64; 225 Window implements WindowBase64;
226 Window implements WindowEventHandlers; 226 Window implements WindowEventHandlers;
227 Window implements WindowTimers; 227 Window implements WindowTimers;
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698