Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/core/page/CreateWindow.h

Issue 2855263004: Throw in window.open() when an invalid URL is being passed (Closed)
Patch Set: updates Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/WebKit/Source/core/frame/Window.idl ('K') | « third_party/WebKit/Source/core/frame/Window.idl ('k') | third_party/WebKit/Source/core/page/CreateWindow.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/page/CreateWindow.h
diff --git a/third_party/WebKit/Source/core/page/CreateWindow.h b/third_party/WebKit/Source/core/page/CreateWindow.h
index 2a69d23035c55fc2e48706d47db959df9bb2892f..ee4d3cc98d072f980e79535126c9b38f8350b910 100644
--- a/third_party/WebKit/Source/core/page/CreateWindow.h
+++ b/third_party/WebKit/Source/core/page/CreateWindow.h
@@ -36,6 +36,7 @@
#undef CreateWindow
namespace blink {
+class ExceptionState;
class LocalFrame;
struct FrameLoadRequest;
struct WindowFeatures;
@@ -45,7 +46,8 @@ DOMWindow* CreateWindow(const String& url_string,
const WindowFeatures&,
LocalDOMWindow& calling_window,
LocalFrame& first_frame,
- LocalFrame& opener_frame);
+ LocalFrame& opener_frame,
+ ExceptionState&);
void CreateWindowForRequest(const FrameLoadRequest&,
LocalFrame& opener_frame,
« third_party/WebKit/Source/core/frame/Window.idl ('K') | « third_party/WebKit/Source/core/frame/Window.idl ('k') | third_party/WebKit/Source/core/page/CreateWindow.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698