Add logging for dup() failure in SharedMemoryHandle.

Add logging for dup() failure in SharedMemoryHandle.

BUG=716536

[erikchen, 2017-05-04 03:08:09]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 03:08:21]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[erikchen, 2017-05-04 03:08:23]

erikchen@chromium.org changed reviewers:
+ thakis@chromium.org

[erikchen, 2017-05-04 03:08:23]

thakis: Please review.

[commit-bot: I haz the power, 2017-05-04 04:12:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 04:12:18]

Dry run: This issue passed the CQ dry run.

[Nico, 2017-05-04 14:02:28]

are you debugging some problem? what's this for?

[erikchen, 2017-05-04 16:02:29]

On 2017/05/04 14:02:28, Nico wrote:
> are you debugging some problem? what's this for?

I removed this debugging in a previous CL and rsesek wanted me to add it back

[Nico, 2017-05-04 16:04:51]

rsesek, what do you want this for?

(I'm not against adding it if someone looks at it, just curious what it's being
used for.)

[Robert Sesek, 2017-05-04 16:21:20]

On 2017/05/04 16:04:51, Nico wrote:
> rsesek, what do you want this for?
> 
> (I'm not against adding it if someone looks at it, just curious what it's
being
> used for.)

I think good logging makes debugging easier.

[Nico, 2017-05-04 17:05:42]

On 2017/05/04 16:21:20, Robert Sesek wrote:
> On 2017/05/04 16:04:51, Nico wrote:
> > rsesek, what do you want this for?
> > 
> > (I'm not against adding it if someone looks at it, just curious what it's
> being
> > used for.)
> 
> I think good logging makes debugging easier.

Having everything logs makes for super noisy tests. The styleguide says
something like "log if you're debugging something, else don't" somewhere iirc.

lgtm if you need it for something since I don't expect this to be noisy, but
test output is full of well-intentioned, bad logging.

[erikchen, 2017-05-04 17:12:26]

On 2017/05/04 17:05:42, Nico wrote:
> On 2017/05/04 16:21:20, Robert Sesek wrote:
> > On 2017/05/04 16:04:51, Nico wrote:
> > > rsesek, what do you want this for?
> > > 
> > > (I'm not against adding it if someone looks at it, just curious what it's
> > being
> > > used for.)
> > 
> > I think good logging makes debugging easier.
> 
> Having everything logs makes for super noisy tests. The styleguide says
> something like "log if you're debugging something, else don't" somewhere iirc.
> 
> lgtm if you need it for something since I don't expect this to be noisy, but
> test output is full of well-intentioned, bad logging.

Closing the issue w/o landing.

[erikchen, 2017-05-04 17:12:31]

Description was changed from

==========
Add logging for dup() failure in SharedMemoryHandle.

BUG=716536
==========

to

==========
Add logging for dup() failure in SharedMemoryHandle.

BUG=716536
==========

[Robert Sesek, 2017-05-05 16:11:39]

On 2017/05/04 17:05:42, Nico wrote:
> On 2017/05/04 16:21:20, Robert Sesek wrote:
> > On 2017/05/04 16:04:51, Nico wrote:
> > > rsesek, what do you want this for?
> > > 
> > > (I'm not against adding it if someone looks at it, just curious what it's
> > being
> > > used for.)
> > 
> > I think good logging makes debugging easier.
> 
> Having everything logs makes for super noisy tests. The styleguide says
> something like "log if you're debugging something, else don't" somewhere iirc.
> 
> lgtm if you need it for something since I don't expect this to be noisy, but
> test output is full of well-intentioned, bad logging.

Chromium is wildly inconsistent about logging practices. If this were going to
produce a lot of noisy logging in tests, then it probably wouldn't be a useful
log to have in general since it'd fire too frequently. But since this should be
an exceptional case, I think logging is warranted.

[Robert Sesek, 2017-05-05 16:12:03]

rsesek@chromium.org changed reviewers:
+ rsesek@chromium.org