supersize: Don't cluster by default. Make Diff() accept only SizeInfo.

supersize: Don't cluster by default. Make Diff() accept only SizeInfo.

Sometimes it's useful to view symbols by address, and clustering them
makes doing so a non-trivial task.

Diff() already have a TODO that it didn't work quite properly for
nested groups. This addresses the TODO by having it act upon the
unclustered symbols.

Moves cluster logic to its own file, and maps it to
SymbolGroup.Cluster().

BUG=681694
Review-Url: https://codereview.chromium.org/2854173003
Cr-Commit-Position: refs/heads/master@{#468989}
Committed: https://chromium.googlesource.com/chromium/src/+/51966e62c532574324c8fe6f6745ceb47160d241

[agrieve, 2017-05-02 19:01:49]

Description was changed from

==========
supersize: Don't cluster by default. Make Diff() accept only SizeInfo.

Sometimes it's useful to view symbols by address, and clustering them
makes doing so a non-trivial task.

Diff() already have a TODO that it didn't work quite properly for
nested groups. This addresses the TODO by having it act upon the
unclustered symbols.

Moves cluster logic to its own file, and maps it to
SymbolGroup.Cluster().

BUG=681694
==========

to

==========
supersize: Don't cluster by default. Make Diff() accept only SizeInfo.

Sometimes it's useful to view symbols by address, and clustering them
makes doing so a non-trivial task.

Diff() already have a TODO that it didn't work quite properly for
nested groups. This addresses the TODO by having it act upon the
unclustered symbols.

Moves cluster logic to its own file, and maps it to
SymbolGroup.Cluster().

BUG=681694
==========

[agrieve, 2017-05-02 19:01:50]

agrieve@chromium.org changed reviewers:
+ estevenson@chromium.org

[estevenson, 2017-05-03 15:26:08]

lgtm

[agrieve, 2017-05-03 15:43:33]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2017-05-03 15:44:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 15:56:02]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493826213712590, "parent_rev":
"97af8a5b4bd46c78ecb55287d6c680b0232bef6d", "commit_rev":
"51966e62c532574324c8fe6f6745ceb47160d241"}

[commit-bot: I haz the power, 2017-05-03 15:56:10]

Description was changed from

==========
supersize: Don't cluster by default. Make Diff() accept only SizeInfo.

Sometimes it's useful to view symbols by address, and clustering them
makes doing so a non-trivial task.

Diff() already have a TODO that it didn't work quite properly for
nested groups. This addresses the TODO by having it act upon the
unclustered symbols.

Moves cluster logic to its own file, and maps it to
SymbolGroup.Cluster().

BUG=681694
==========

to

==========
supersize: Don't cluster by default. Make Diff() accept only SizeInfo.

Sometimes it's useful to view symbols by address, and clustering them
makes doing so a non-trivial task.

Diff() already have a TODO that it didn't work quite properly for
nested groups. This addresses the TODO by having it act upon the
unclustered symbols.

Moves cluster logic to its own file, and maps it to
SymbolGroup.Cluster().

BUG=681694

Review-Url: https://codereview.chromium.org/2854173003
Cr-Commit-Position: refs/heads/master@{#468989}
Committed:
https://chromium.googlesource.com/chromium/src/+/51966e62c532574324c8fe6f6745...
==========

[commit-bot: I haz the power, 2017-05-03 15:56:11]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/51966e62c532574324c8fe6f6745...