Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Issue 2858793002: Create a star symbol for gaps at the start & end of sections (Closed)

Created:
3 years, 7 months ago by agrieve
Modified:
3 years, 7 months ago
Reviewers:
estevenson
CC:
chromium-reviews, wnwen+watch_chromium.org, estevenson+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Create a star symbol for gaps at the start & end of sections This eliminates the chance of a diff coming up where the symbols do not sum up to the entire section delta Other misc changes here: * Improves the size summary messaging. * Kills nm subprocess upon exit (rather than letting process finish) * Allows linker maps to not have a Common Symbols section BUG=714180 Review-Url: https://codereview.chromium.org/2858793002 Cr-Commit-Position: refs/heads/master@{#469017} Committed: https://chromium.googlesource.com/chromium/src/+/2de1cc0bc6bfc831331f083e8434f15c11ad9021

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+347 lines, -270 lines) Patch
M tools/binary_size/libsupersize/archive.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/binary_size/libsupersize/cluster_symbols.py View 4 chunks +21 lines, -21 lines 0 comments Download
M tools/binary_size/libsupersize/describe.py View 2 chunks +26 lines, -26 lines 0 comments Download
M tools/binary_size/libsupersize/linker_map_parser.py View 5 chunks +40 lines, -22 lines 0 comments Download
M tools/binary_size/libsupersize/models.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/binary_size/libsupersize/nm.py View 7 chunks +27 lines, -5 lines 0 comments Download
M tools/binary_size/libsupersize/testdata/Archive.golden View 3 chunks +14 lines, -13 lines 0 comments Download
M tools/binary_size/libsupersize/testdata/Archive_Elf.golden View 3 chunks +15 lines, -14 lines 0 comments Download
M tools/binary_size/libsupersize/testdata/Archive_OutputDirectory.golden View 3 chunks +14 lines, -13 lines 0 comments Download
M tools/binary_size/libsupersize/testdata/Console.golden View 1 chunk +55 lines, -45 lines 0 comments Download
M tools/binary_size/libsupersize/testdata/Diff_Basic.golden View 2 chunks +12 lines, -3 lines 0 comments Download
M tools/binary_size/libsupersize/testdata/Diff_NullDiff.golden View 1 chunk +1 line, -1 line 0 comments Download
M tools/binary_size/libsupersize/testdata/FullDescription.golden View 2 chunks +78 lines, -64 lines 0 comments Download
M tools/binary_size/libsupersize/testdata/SymbolGroupMethods.golden View 1 chunk +42 lines, -42 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 9 (5 generated)
agrieve
On 2017/05/02 23:06:40, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:estevenson@chromium.org 🐛
3 years, 7 months ago (2017-05-02 23:06:47 UTC) #3
estevenson
lgtm
3 years, 7 months ago (2017-05-03 17:02:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858793002/1
3 years, 7 months ago (2017-05-03 17:11:29 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 17:23:28 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2de1cc0bc6bfc831331f083e8434...

Powered by Google App Engine
This is Rietveld 408576698