Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: tools/binary_size/libsupersize/integration_test.py

Issue 2854173003: supersize: Don't cluster by default. Make Diff() accept only SizeInfo. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/binary_size/libsupersize/file_format.py ('k') | tools/binary_size/libsupersize/models.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/binary_size/libsupersize/integration_test.py
diff --git a/tools/binary_size/libsupersize/integration_test.py b/tools/binary_size/libsupersize/integration_test.py
index d0f6702cd4f5e1af6095e3d47e6fab17cf469480..6e27a2c8ec3499462caab45371241db1f3ec6dba 100755
--- a/tools/binary_size/libsupersize/integration_test.py
+++ b/tools/binary_size/libsupersize/integration_test.py
@@ -121,10 +121,8 @@ class IntegrationTest(unittest.TestCase):
expected_size_info = self._CloneSizeInfo(
use_output_directory=use_output_directory, use_elf=use_elf)
self.assertEquals(expected_size_info.metadata, size_info.metadata)
- expected = list(describe.GenerateLines(
- expected_size_info, verbose=True, recursive=True))
- actual = list(describe.GenerateLines(
- size_info, verbose=True, recursive=True))
+ expected = list(describe.GenerateLines(expected_size_info.Cluster()))
+ actual = list(describe.GenerateLines(size_info.Cluster()))
self.assertEquals(expected, actual)
sym_strs = (repr(sym) for sym in size_info.symbols)
@@ -185,59 +183,63 @@ class IntegrationTest(unittest.TestCase):
return describe.GenerateLines(d, verbose=True)
def test_Diff_Aliases1(self):
- symbols1 = self._CloneSizeInfo().symbols
- symbols2 = self._CloneSizeInfo().symbols
+ size_info1 = self._CloneSizeInfo()
+ size_info2 = self._CloneSizeInfo()
# Removing 1 alias should not change the size.
- a1, _, _ = symbols2.Filter(lambda s: s.num_aliases == 3)[0].aliases
- symbols2 -= [a1]
+ a1, _, _ = (
+ size_info2.symbols.Filter(lambda s: s.num_aliases == 3)[0].aliases)
+ size_info2.symbols -= [a1]
a1.aliases.remove(a1)
- d = diff.Diff(symbols1, symbols2)
- self.assertEquals(d.size, 0)
- self.assertEquals(d.removed_count, 1)
+ d = diff.Diff(size_info1, size_info2)
+ self.assertEquals(d.symbols.size, 0)
+ self.assertEquals(d.symbols.removed_count, 1)
# Adding one alias should not change size.
- d = diff.Diff(symbols2, symbols1)
- self.assertEquals(d.size, 0)
- self.assertEquals(d.added_count, 1)
+ d = diff.Diff(size_info2, size_info1)
+ self.assertEquals(d.symbols.size, 0)
+ self.assertEquals(d.symbols.added_count, 1)
def test_Diff_Aliases2(self):
- symbols1 = self._CloneSizeInfo().symbols
- symbols2 = self._CloneSizeInfo().symbols
+ size_info1 = self._CloneSizeInfo()
+ size_info2 = self._CloneSizeInfo()
# Removing 2 aliases should not change the size.
- a1, a2, _ = symbols2.Filter(lambda s: s.num_aliases == 3)[0].aliases
- symbols2 -= [a1, a2]
+ a1, a2, _ = (
+ size_info2.symbols.Filter(lambda s: s.num_aliases == 3)[0].aliases)
+ size_info2.symbols -= [a1, a2]
a1.aliases.remove(a1)
a1.aliases.remove(a2)
- d = diff.Diff(symbols1, symbols2)
- self.assertEquals(d.size, 0)
- self.assertEquals(d.removed_count, 2)
+ d = diff.Diff(size_info1, size_info2)
+ self.assertEquals(d.symbols.size, 0)
+ self.assertEquals(d.symbols.removed_count, 2)
# Adding 2 aliases should not change size.
- d = diff.Diff(symbols2, symbols1)
- self.assertEquals(d.size, 0)
- self.assertEquals(d.added_count, 2)
+ d = diff.Diff(size_info2, size_info1)
+ self.assertEquals(d.symbols.size, 0)
+ self.assertEquals(d.symbols.added_count, 2)
def test_Diff_Aliases3(self):
- symbols1 = self._CloneSizeInfo().symbols
- symbols2 = self._CloneSizeInfo().symbols
+ size_info1 = self._CloneSizeInfo()
+ size_info2 = self._CloneSizeInfo()
# Removing all 3 aliases should change the size.
- a1, a2, a3 = symbols2.Filter(lambda s: s.num_aliases == 3)[0].aliases
- symbols2 -= [a1, a2, a3]
- d = diff.Diff(symbols1, symbols2)
- self.assertEquals(d.size, -a1.size)
- self.assertEquals(d.removed_count, 3)
+ a1, a2, a3 = (
+ size_info2.symbols.Filter(lambda s: s.num_aliases == 3)[0].aliases)
+ size_info2.symbols -= [a1, a2, a3]
+ d = diff.Diff(size_info1, size_info2)
+ self.assertEquals(d.symbols.size, -a1.size)
+ self.assertEquals(d.symbols.removed_count, 3)
# Adding all 3 aliases should change size.
- d = diff.Diff(symbols2, symbols1)
- self.assertEquals(d.size, a1.size)
- self.assertEquals(d.added_count, 3)
+ d = diff.Diff(size_info2, size_info1)
+ self.assertEquals(d.symbols.size, a1.size)
+ self.assertEquals(d.symbols.added_count, 3)
@_CompareWithGolden()
def test_FullDescription(self):
- return describe.GenerateLines(self._CloneSizeInfo())
+ return describe.GenerateLines(self._CloneSizeInfo().Cluster(),
+ recursive=True, verbose=True)
@_CompareWithGolden()
def test_SymbolGroupMethods(self):
« no previous file with comments | « tools/binary_size/libsupersize/file_format.py ('k') | tools/binary_size/libsupersize/models.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698