Reland of Make InsertTextCommand not to apply style for empty selection

Reland of Make InsertTextCommand not to apply style for empty selection (patchset #1 id:1 of https://codereview.chromium.org/2853213002/ )

Reason for revert:
Hmm, interestingly enough, the tests were still broken in the build which had the revert: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20%28dbg%29/builds/1512

So I am relanding it.

Original issue's description:
> Revert of Make InsertTextCommand not to apply style for empty selection (patchset #1 id:1 of https://codereview.chromium.org/2847763004/ )
> 
> Reason for revert:
> Speculative revert, this seems to have broken some virtual/gpu/fast/canvas/ tests. More info on the associated bug.
> 
> BUG=717389
> 
> Original issue's description:
> > Make InsertTextCommand not to apply typing style for empty selection
> > 
> > This patch makes |InsertTextCommand::DoApply()| not to call |ApplyStyle()| for
> > applying typing style when selection after inserting text is empty since
> > |ApplyStyle()| doesn't work with empty selection.
> > 
> > The issue 714311 and the attached test case insert text into OPTION element to
> > get empty selection after insertion, since we can't place selection inside
> > OPTION element.
> > 
> > BUG=714311
> > TEST=run_webkit_unit_tests --gtest_filter=InsertTextCommandTest.WithTypingStyle
> > 
> > Review-Url: https://codereview.chromium.org/2847763004
> > Cr-Commit-Position: refs/heads/master@{#468080}
> > Committed: https://chromium.googlesource.com/chromium/src/+/89209614959b6d3b2d4c4e8b015232663b4fcd87
> 
> TBR=xiaochengh@chromium.org,yoichio@chromium.org,yosin@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=714311
> 
> Review-Url: https://codereview.chromium.org/2853213002
> Cr-Commit-Position: refs/heads/master@{#468590}
> Committed: https://chromium.googlesource.com/chromium/src/+/5c9d124ac2131f4765f86902ff4cf711ed96c37e

TBR=xiaochengh@chromium.org,yoichio@chromium.org,yosin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=717389
Review-Url: https://codereview.chromium.org/2854123002
Cr-Commit-Position: refs/heads/master@{#468642}
Committed: https://chromium.googlesource.com/chromium/src/+/6192661b83f875baac41bd4ff9c1d238a702d89c

[vabr (Chromium), 2017-05-02 15:31:03]

The CQ bit was checked by vabr@chromium.org

[vabr (Chromium), 2017-05-02 15:31:03]

Created Reland of Make InsertTextCommand not to apply style for empty selection

[commit-bot: I haz the power, 2017-05-02 15:32:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 15:32:51]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493739063451070, "parent_rev":
"20f63c58374f5028b3d70c153afa10e2beec3052", "commit_rev":
"6192661b83f875baac41bd4ff9c1d238a702d89c"}

[commit-bot: I haz the power, 2017-05-02 15:33:06]

Description was changed from

==========
Reland of Make InsertTextCommand not to apply style for empty selection
(patchset #1 id:1 of https://codereview.chromium.org/2853213002/ )

Reason for revert:
Hmm, interestingly enough, the tests were still broken in the build which had
the revert:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty...

So I am relanding it.

Original issue's description:
> Revert of Make InsertTextCommand not to apply style for empty selection
(patchset #1 id:1 of https://codereview.chromium.org/2847763004/ )
> 
> Reason for revert:
> Speculative revert, this seems to have broken some virtual/gpu/fast/canvas/
tests. More info on the associated bug.
> 
> BUG=717389
> 
> Original issue's description:
> > Make InsertTextCommand not to apply typing style for empty selection
> > 
> > This patch makes |InsertTextCommand::DoApply()| not to call |ApplyStyle()|
for
> > applying typing style when selection after inserting text is empty since
> > |ApplyStyle()| doesn't work with empty selection.
> > 
> > The issue 714311 and the attached test case insert text into OPTION element
to
> > get empty selection after insertion, since we can't place selection inside
> > OPTION element.
> > 
> > BUG=714311
> > TEST=run_webkit_unit_tests
--gtest_filter=InsertTextCommandTest.WithTypingStyle
> > 
> > Review-Url: https://codereview.chromium.org/2847763004
> > Cr-Commit-Position: refs/heads/master@{#468080}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/89209614959b6d3b2d4c4e8b0152...
> 
> TBR=xiaochengh@chromium.org,yoichio@chromium.org,yosin@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=714311
> 
> Review-Url: https://codereview.chromium.org/2853213002
> Cr-Commit-Position: refs/heads/master@{#468590}
> Committed:
https://chromium.googlesource.com/chromium/src/+/5c9d124ac2131f4765f86902ff4c...

TBR=xiaochengh@chromium.org,yoichio@chromium.org,yosin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=717389
==========

to

==========
Reland of Make InsertTextCommand not to apply style for empty selection
(patchset #1 id:1 of https://codereview.chromium.org/2853213002/ )

Reason for revert:
Hmm, interestingly enough, the tests were still broken in the build which had
the revert:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty...

So I am relanding it.

Original issue's description:
> Revert of Make InsertTextCommand not to apply style for empty selection
(patchset #1 id:1 of https://codereview.chromium.org/2847763004/ )
> 
> Reason for revert:
> Speculative revert, this seems to have broken some virtual/gpu/fast/canvas/
tests. More info on the associated bug.
> 
> BUG=717389
> 
> Original issue's description:
> > Make InsertTextCommand not to apply typing style for empty selection
> > 
> > This patch makes |InsertTextCommand::DoApply()| not to call |ApplyStyle()|
for
> > applying typing style when selection after inserting text is empty since
> > |ApplyStyle()| doesn't work with empty selection.
> > 
> > The issue 714311 and the attached test case insert text into OPTION element
to
> > get empty selection after insertion, since we can't place selection inside
> > OPTION element.
> > 
> > BUG=714311
> > TEST=run_webkit_unit_tests
--gtest_filter=InsertTextCommandTest.WithTypingStyle
> > 
> > Review-Url: https://codereview.chromium.org/2847763004
> > Cr-Commit-Position: refs/heads/master@{#468080}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/89209614959b6d3b2d4c4e8b0152...
> 
> TBR=xiaochengh@chromium.org,yoichio@chromium.org,yosin@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=714311
> 
> Review-Url: https://codereview.chromium.org/2853213002
> Cr-Commit-Position: refs/heads/master@{#468590}
> Committed:
https://chromium.googlesource.com/chromium/src/+/5c9d124ac2131f4765f86902ff4c...

TBR=xiaochengh@chromium.org,yoichio@chromium.org,yosin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=717389

Review-Url: https://codereview.chromium.org/2854123002
Cr-Commit-Position: refs/heads/master@{#468642}
Committed:
https://chromium.googlesource.com/chromium/src/+/6192661b83f875baac41bd4ff9c1...
==========

[commit-bot: I haz the power, 2017-05-02 15:33:10]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6192661b83f875baac41bd4ff9c1...