Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2853213002: Revert of Make InsertTextCommand not to apply style for empty selection (Closed)

Created:
3 years, 7 months ago by vabr (Chromium)
Modified:
3 years, 7 months ago
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make InsertTextCommand not to apply style for empty selection (patchset #1 id:1 of https://codereview.chromium.org/2847763004/ ) Reason for revert: Speculative revert, this seems to have broken some virtual/gpu/fast/canvas/ tests. More info on the associated bug. BUG=717389 Original issue's description: > Make InsertTextCommand not to apply typing style for empty selection > > This patch makes |InsertTextCommand::DoApply()| not to call |ApplyStyle()| for > applying typing style when selection after inserting text is empty since > |ApplyStyle()| doesn't work with empty selection. > > The issue 714311 and the attached test case insert text into OPTION element to > get empty selection after insertion, since we can't place selection inside > OPTION element. > > BUG=714311 > TEST=run_webkit_unit_tests --gtest_filter=InsertTextCommandTest.WithTypingStyle > > Review-Url: https://codereview.chromium.org/2847763004 > Cr-Commit-Position: refs/heads/master@{#468080} > Committed: https://chromium.googlesource.com/chromium/src/+/89209614959b6d3b2d4c4e8b015232663b4fcd87 TBR=xiaochengh@chromium.org,yoichio@chromium.org,yosin@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=714311 Review-Url: https://codereview.chromium.org/2853213002 Cr-Commit-Position: refs/heads/master@{#468590} Committed: https://chromium.googlesource.com/chromium/src/+/5c9d124ac2131f4765f86902ff4cf711ed96c37e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -36 lines) Patch
M third_party/WebKit/Source/core/editing/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/core/editing/commands/InsertTextCommandTest.cpp View 1 chunk +0 lines, -34 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
vabr (Chromium)
Created Revert of Make InsertTextCommand not to apply style for empty selection
3 years, 7 months ago (2017-05-02 07:55:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2853213002/1
3 years, 7 months ago (2017-05-02 07:56:03 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/5c9d124ac2131f4765f86902ff4cf711ed96c37e
3 years, 7 months ago (2017-05-02 09:54:08 UTC) #6
vabr (Chromium)
3 years, 7 months ago (2017-05-02 15:31:03 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2854123002/ by vabr@chromium.org.

The reason for reverting is: Hmm, interestingly enough, the tests were still
broken in the build which had the revert:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty...

So I am relanding it..

Powered by Google App Engine
This is Rietveld 408576698