Make InsertTextCommand not to apply style for empty selection

Make InsertTextCommand not to apply typing style for empty selection

This patch makes |InsertTextCommand::DoApply()| not to call |ApplyStyle()| for
applying typing style when selection after inserting text is empty since
|ApplyStyle()| doesn't work with empty selection.

The issue 714311 and the attached test case insert text into OPTION element to
get empty selection after insertion, since we can't place selection inside
OPTION element.

BUG=714311
TEST=run_webkit_unit_tests --gtest_filter=InsertTextCommandTest.WithTypingStyle

Review-Url: https://codereview.chromium.org/2847763004
Cr-Commit-Position: refs/heads/master@{#468080}
Committed: https://chromium.googlesource.com/chromium/src/+/89209614959b6d3b2d4c4e8b015232663b4fcd87

[yosin_UTC9, 2017-04-28 05:42:11]

Description was changed from

==========
Make InsertTextCommand not to apply style for empty selection

BUG=714311
TEST=run_webkit_unit_tests --gtest_filter=InsertTextCommandTest.WithTypingStyle
==========

to

==========
Make InsertTextCommand not to apply style for empty selection

TBD

BUG=714311
TEST=run_webkit_unit_tests --gtest_filter=InsertTextCommandTest.WithTypingStyle
==========

[yosin_UTC9, 2017-04-28 05:43:17]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 05:43:36]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 07:29:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 07:29:28]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2017-04-28 08:18:18]

Description was changed from

==========
Make InsertTextCommand not to apply style for empty selection

TBD

BUG=714311
TEST=run_webkit_unit_tests --gtest_filter=InsertTextCommandTest.WithTypingStyle
==========

to

==========
Make InsertTextCommand not to apply typing style for empty selection

This patch makes |InsertTextCommand::DoApply()| not to call |ApplyStyle()| for
applying typing style when selection after inserting text is empty since
|ApplyStyle()| doesn't work with empty selection.

The issue 714311 and the attached test case insert text into OPTION element to
get empty selection after insertion, since we can't place selection inside
OPTION element.

BUG=714311
TEST=run_webkit_unit_tests --gtest_filter=InsertTextCommandTest.WithTypingStyle
==========

[yosin_UTC9, 2017-04-28 08:18:43]

yosin@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2017-04-28 08:18:44]

PTAL

Please click [Commit] button since I'm OOO until May 8.
Thanks!

[Xiaocheng, 2017-04-28 18:39:40]

The CQ bit was checked by xiaochengh@chromium.org

[Xiaocheng, 2017-04-28 18:39:40]

lgtm

[commit-bot: I haz the power, 2017-04-28 18:40:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 18:58:04]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493404780337220, "parent_rev":
"cff98375334e29507d061fd93d4e9146c785f43f", "commit_rev":
"89209614959b6d3b2d4c4e8b015232663b4fcd87"}

[commit-bot: I haz the power, 2017-04-28 18:58:23]

Description was changed from

==========
Make InsertTextCommand not to apply typing style for empty selection

This patch makes |InsertTextCommand::DoApply()| not to call |ApplyStyle()| for
applying typing style when selection after inserting text is empty since
|ApplyStyle()| doesn't work with empty selection.

The issue 714311 and the attached test case insert text into OPTION element to
get empty selection after insertion, since we can't place selection inside
OPTION element.

BUG=714311
TEST=run_webkit_unit_tests --gtest_filter=InsertTextCommandTest.WithTypingStyle
==========

to

==========
Make InsertTextCommand not to apply typing style for empty selection

This patch makes |InsertTextCommand::DoApply()| not to call |ApplyStyle()| for
applying typing style when selection after inserting text is empty since
|ApplyStyle()| doesn't work with empty selection.

The issue 714311 and the attached test case insert text into OPTION element to
get empty selection after insertion, since we can't place selection inside
OPTION element.

BUG=714311
TEST=run_webkit_unit_tests --gtest_filter=InsertTextCommandTest.WithTypingStyle

Review-Url: https://codereview.chromium.org/2847763004
Cr-Commit-Position: refs/heads/master@{#468080}
Committed:
https://chromium.googlesource.com/chromium/src/+/89209614959b6d3b2d4c4e8b0152...
==========

[commit-bot: I haz the power, 2017-04-28 18:58:24]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/89209614959b6d3b2d4c4e8b0152...

[vabr (Chromium), 2017-05-02 07:55:48]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2853213002/ by vabr@chromium.org.

The reason for reverting is: Speculative revert, this seems to have broken some
virtual/gpu/fast/canvas/ tests. More info on the associated bug.

BUG=717389.