Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1305)

Issue 2853433003: Generate enum/getters/setters/mappings for box-sizing. (Closed)

Created:
3 years, 7 months ago by shend
Modified:
3 years, 7 months ago
Reviewers:
meade_UTC10, nainar
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Generate enum/getters/setters/mappings for box-sizing. Currently, the box-sizing property is a 'storage_only' field, so it has no generated public getters/setters. This patch changes it to a 'keyword' field so that their getters/setters can be generated as well. We also generate the EBoxSizing enum and use the generated CSSValueID <-> EBoxSizing mappings. Diff of generated files: https://gist.github.com/darrnshn/cb6f24173e65563f8a2c755a4db10836/revisions BUG=628043 Review-Url: https://codereview.chromium.org/2853433003 Cr-Commit-Position: refs/heads/master@{#471665} Committed: https://chromium.googlesource.com/chromium/src/+/e0255eded6d4fb960323b8aa66065783ea9ae5e1

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -50 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 1 1 chunk +0 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 1 1 chunk +8 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5 View 1 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 1 chunk +0 lines, -4 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 35 (28 generated)
shend
Hi Naina, PTAL
3 years, 7 months ago (2017-05-09 00:21:37 UTC) #2
nainar
lgtm
3 years, 7 months ago (2017-05-09 00:26:53 UTC) #3
shend
Hi Eddy, PTAL
3 years, 7 months ago (2017-05-11 23:27:24 UTC) #10
meade_UTC10
lgtm
3 years, 7 months ago (2017-05-12 04:24:53 UTC) #14
commit-bot: I haz the power
This CL has an open dependency (Issue 2846153002 Patch 20001). Please resolve the dependency and ...
3 years, 7 months ago (2017-05-15 03:37:11 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2853433003/20001
3 years, 7 months ago (2017-05-15 04:14:14 UTC) #32
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 04:18:53 UTC) #35
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e0255eded6d4fb960323b8aa6606...

Powered by Google App Engine
This is Rietveld 408576698