Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2846153002:
Generate getters/setters for (/min/max)(width/height). (Closed)
DescriptionGenerate getters/setters for (/min/max)(width/height).
Currently, width, height, min-width, max-width, min-height, max-height
are generated as 'storage_only' fields, so they have no generated public
getters/setters. This patch changes them to 'external' fields so that
their getters/setters can be generated as well.
Diff of generated files:
https://gist.github.com/darrnshn/da85715450bd51e48cb1384a9ee9b1bb/revisions
BUG=628043
Review-Url: https://codereview.chromium.org/2846153002
Cr-Commit-Position: refs/heads/master@{#471661}
Committed: https://chromium.googlesource.com/chromium/src/+/fe5ff7fddaf55aa6edfdad13f192089d25e7e3a8
Patch Set 1 #Patch Set 2 : Rebase #
Depends on Patchset: Dependent Patchsets: Messages
Total messages: 32 (25 generated)
Description was changed from ========== Generate getters/setters for (/min/max)(width/height). Currently, width, height, min-width, max-width, min-height, max-height are generated as 'storage_only' fields, so they have no generated public getters/setters. This patch changes them to 'external' fields so that their getters/setters can be generated as well. BUG=628043 ========== to ========== Generate getters/setters for (/min/max)(width/height). Currently, width, height, min-width, max-width, min-height, max-height are generated as 'storage_only' fields, so they have no generated public getters/setters. This patch changes them to 'external' fields so that their getters/setters can be generated as well. Diff of generated files: https://gist.github.com/darrnshn/da85715450bd51e48cb1384a9ee9b1bb/revisions BUG=628043 ==========
shend@chromium.org changed reviewers: + nainar@chromium.org
Hi Naina, PTAL
lgtm
rune@opera.com changed reviewers: + rune@opera.com
rs lgtm
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by shend@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nainar@chromium.org, rune@opera.com Link to the patchset: https://codereview.chromium.org/2846153002/#ps20001 (title: "Rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?))
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by shend@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494819443361740,
"parent_rev": "d06138094fbdff17a1a18e4bc933bddf87732ab5", "commit_rev":
"fe5ff7fddaf55aa6edfdad13f192089d25e7e3a8"}
Message was sent while issue was closed.
Description was changed from ========== Generate getters/setters for (/min/max)(width/height). Currently, width, height, min-width, max-width, min-height, max-height are generated as 'storage_only' fields, so they have no generated public getters/setters. This patch changes them to 'external' fields so that their getters/setters can be generated as well. Diff of generated files: https://gist.github.com/darrnshn/da85715450bd51e48cb1384a9ee9b1bb/revisions BUG=628043 ========== to ========== Generate getters/setters for (/min/max)(width/height). Currently, width, height, min-width, max-width, min-height, max-height are generated as 'storage_only' fields, so they have no generated public getters/setters. This patch changes them to 'external' fields so that their getters/setters can be generated as well. Diff of generated files: https://gist.github.com/darrnshn/da85715450bd51e48cb1384a9ee9b1bb/revisions BUG=628043 Review-Url: https://codereview.chromium.org/2846153002 Cr-Commit-Position: refs/heads/master@{#471661} Committed: https://chromium.googlesource.com/chromium/src/+/fe5ff7fddaf55aa6edfdad13f192... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/fe5ff7fddaf55aa6edfdad13f192... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
