Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2844083005: Generate enum/getters/setters/mappings for box-decoration-break. (Closed)

Created:
3 years, 7 months ago by shend
Modified:
3 years, 7 months ago
Reviewers:
meade_UTC10, nainar
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Generate enum/getters/setters/mappings for box-decoration-break. Currently, the box-decoration-break property is a 'storage_only' field, so it has no generated public getters/setters. This patch changes it to a 'keyword' field so that its getters/setters can be generated as well. We also generate the EBoxDecorationBreak enum and use the generated CSSValueID <-> EBoxDecorationBreak mappings. Diff of generated files: https://gist.github.com/3e209733463b455cb70fb4f1c95435c9/revisions BUG=628043 Review-Url: https://codereview.chromium.org/2844083005 Cr-Commit-Position: refs/heads/master@{#471675} Committed: https://chromium.googlesource.com/chromium/src/+/85a9925c6310cf115ea694e08d1ad332bfc1e09a

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -52 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 1 1 chunk +0 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 1 1 chunk +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5 View 1 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 1 chunk +0 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 29 (23 generated)
shend
Hi Naina, PTAL
3 years, 7 months ago (2017-05-09 00:21:49 UTC) #7
nainar
lgtm
3 years, 7 months ago (2017-05-09 00:27:29 UTC) #8
shend
Hi Eddy, PTAL
3 years, 7 months ago (2017-05-11 23:27:40 UTC) #14
meade_UTC10
lgtm
3 years, 7 months ago (2017-05-12 05:11:21 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2844083005/20001
3 years, 7 months ago (2017-05-15 05:27:44 UTC) #26
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 05:31:48 UTC) #29
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/85a9925c6310cf115ea694e08d1a...

Powered by Google App Engine
This is Rietveld 408576698