Improve error message when debuggers not installed

Improve error message when debuggers not installed

When building Chrome we require that you have the "Debugging tools for
Windows" feature of the Windows 10 SDK installed. The error messages
when this non-default component is not installed are a bit cryptic. This
adds a more explicit error message.

The new error message looks like this:

>gn gen out\debug
Traceback (most recent call last):
  File "c:/src/chromium4/src/build/vs_toolchain.py", line 448, in <module>
    sys.exit(main())
  File "c:/src/chromium4/src/build/vs_toolchain.py", line 444, in main
    return commands[sys.argv[1]](*sys.argv[2:])
  File "c:/src/chromium4/src/build/vs_toolchain.py", line 309, in CopyDlls
    _CopyDebugger(target_dir, target_cpu)
  File "c:/src/chromium4/src/build/vs_toolchain.py", line 331, in _CopyDebugger
    '10 SDK.' % full_path)
Exception: dbghelp.dll not found in "C:\Program Files (x86)\Windows Kits\10\Debuggers\x86\dbghelp.dll"
You must install the "Debugging Tools for Windows" feature from the Windows 10 SDK.
ERROR at //build/toolchain/win/BUILD.gn:39:3: Script returned non-zero exit code.
  exec_script("../../vs_toolchain.py",
  ^----------
Current dir: c:/src/chromium4/src/out/debug/
Command: C:/src/depot_tools/python276_bin/python.exe -- c:/src/chromium4/src/build/vs_toolchain.py copy_dlls c:/src/chromium4/src/out/debug Debug x86
Returned 1.
See //BUILD.gn:65:1: which caused the file to be included.
group("gn_all") {
^----------------

R=wkorman@chromium.org
BUG=702697
Review-Url: https://codereview.chromium.org/2853083002
Cr-Commit-Position: refs/heads/master@{#468397}
Committed: https://chromium.googlesource.com/chromium/src/+/6c3d410ea272423ac277dc3f3e3def6490dfd6dc

[brucedawson, 2017-05-01 18:19:01]

Description was changed from

==========
Ignore error message when debuggers not installed

When building Chrome we require that you have the "Debugging tools for
Windows" feature of the Windows 10 SDK installed. The error messages
when this non-default component is not installed are a bit cryptic. This
adds a more explicit error message.

R=wkorman@chromium.org
BUG=702697
==========

to

==========
Ignore error message when debuggers not installed

When building Chrome we require that you have the "Debugging tools for
Windows" feature of the Windows 10 SDK installed. The error messages
when this non-default component is not installed are a bit cryptic. This
adds a more explicit error message.

The new error message looks like this:

>gn gen out\debug
Traceback (most recent call last):
  File "c:/src/chromium4/src/build/vs_toolchain.py", line 448, in <module>
    sys.exit(main())
  File "c:/src/chromium4/src/build/vs_toolchain.py", line 444, in main
    return commands[sys.argv[1]](*sys.argv[2:])
  File "c:/src/chromium4/src/build/vs_toolchain.py", line 309, in CopyDlls
    _CopyDebugger(target_dir, target_cpu)
  File "c:/src/chromium4/src/build/vs_toolchain.py", line 331, in _CopyDebugger
    '10 SDK.' % full_path)
Exception: dbghelp.dll not found in "C:\Program Files (x86)\Windows
Kits\10\Debuggers\x86\dbghelp.dll"
You must install the "Debugging Tools for Windows" feature from the Windows 10
SDK.
ERROR at //build/toolchain/win/BUILD.gn:39:3: Script returned non-zero exit
code.
  exec_script("../../vs_toolchain.py",
  ^----------
Current dir: c:/src/chromium4/src/out/debug/
Command: C:/src/depot_tools/python276_bin/python.exe --
c:/src/chromium4/src/build/vs_toolchain.py copy_dlls
c:/src/chromium4/src/out/debug Debug x86
Returned 1.
See //BUILD.gn:65:1: which caused the file to be included.
group("gn_all") {
^----------------

R=wkorman@chromium.org
BUG=702697
==========

[brucedawson, 2017-05-01 18:19:22]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[brucedawson, 2017-05-01 18:19:50]

PTAL.

Note that cdb.exe is no longer needed, but dbghelp.dll still is.

[commit-bot: I haz the power, 2017-05-01 18:20:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brucedawson, 2017-05-01 18:27:45]

Description was changed from

==========
Ignore error message when debuggers not installed

When building Chrome we require that you have the "Debugging tools for
Windows" feature of the Windows 10 SDK installed. The error messages
when this non-default component is not installed are a bit cryptic. This
adds a more explicit error message.

The new error message looks like this:

>gn gen out\debug
Traceback (most recent call last):
  File "c:/src/chromium4/src/build/vs_toolchain.py", line 448, in <module>
    sys.exit(main())
  File "c:/src/chromium4/src/build/vs_toolchain.py", line 444, in main
    return commands[sys.argv[1]](*sys.argv[2:])
  File "c:/src/chromium4/src/build/vs_toolchain.py", line 309, in CopyDlls
    _CopyDebugger(target_dir, target_cpu)
  File "c:/src/chromium4/src/build/vs_toolchain.py", line 331, in _CopyDebugger
    '10 SDK.' % full_path)
Exception: dbghelp.dll not found in "C:\Program Files (x86)\Windows
Kits\10\Debuggers\x86\dbghelp.dll"
You must install the "Debugging Tools for Windows" feature from the Windows 10
SDK.
ERROR at //build/toolchain/win/BUILD.gn:39:3: Script returned non-zero exit
code.
  exec_script("../../vs_toolchain.py",
  ^----------
Current dir: c:/src/chromium4/src/out/debug/
Command: C:/src/depot_tools/python276_bin/python.exe --
c:/src/chromium4/src/build/vs_toolchain.py copy_dlls
c:/src/chromium4/src/out/debug Debug x86
Returned 1.
See //BUILD.gn:65:1: which caused the file to be included.
group("gn_all") {
^----------------

R=wkorman@chromium.org
BUG=702697
==========

to

==========
Improve error message when debuggers not installed

When building Chrome we require that you have the "Debugging tools for
Windows" feature of the Windows 10 SDK installed. The error messages
when this non-default component is not installed are a bit cryptic. This
adds a more explicit error message.

The new error message looks like this:

>gn gen out\debug
Traceback (most recent call last):
  File "c:/src/chromium4/src/build/vs_toolchain.py", line 448, in <module>
    sys.exit(main())
  File "c:/src/chromium4/src/build/vs_toolchain.py", line 444, in main
    return commands[sys.argv[1]](*sys.argv[2:])
  File "c:/src/chromium4/src/build/vs_toolchain.py", line 309, in CopyDlls
    _CopyDebugger(target_dir, target_cpu)
  File "c:/src/chromium4/src/build/vs_toolchain.py", line 331, in _CopyDebugger
    '10 SDK.' % full_path)
Exception: dbghelp.dll not found in "C:\Program Files (x86)\Windows
Kits\10\Debuggers\x86\dbghelp.dll"
You must install the "Debugging Tools for Windows" feature from the Windows 10
SDK.
ERROR at //build/toolchain/win/BUILD.gn:39:3: Script returned non-zero exit
code.
  exec_script("../../vs_toolchain.py",
  ^----------
Current dir: c:/src/chromium4/src/out/debug/
Command: C:/src/depot_tools/python276_bin/python.exe --
c:/src/chromium4/src/build/vs_toolchain.py copy_dlls
c:/src/chromium4/src/out/debug Debug x86
Returned 1.
See //BUILD.gn:65:1: which caused the file to be included.
group("gn_all") {
^----------------

R=wkorman@chromium.org
BUG=702697
==========

[wkorman, 2017-05-01 18:40:20]

lgtm

https://codereview.chromium.org/2853083002/diff/1/build/vs_toolchain.py
File build/vs_toolchain.py (right):

https://codereview.chromium.org/2853083002/diff/1/build/vs_toolchain.py#newco...
build/vs_toolchain.py:331: '10 SDK.' % full_path)
Is there a page worth linking to directly? I found four from Google searching,
with varying dead links, these look like the two that I might explore:

https://developer.microsoft.com/en-us/windows/hardware/windows-driver-kit
https://developer.microsoft.com/en-us/windows/hardware/download-windbg

I realize the urls change often so maybe it's not worth including but thought
worth brief discussion. Since I think the way I probably got into trouble is
that one of the above is the right one, but even now I am not sure which.

And maybe VS 2017 even has an in-app checkbox that in theory installs the thing,
separate from above two urls/installers, but I am not sure that worked for me
per previous bug discussion.

[brucedawson, 2017-05-01 18:42:58]

On 2017/05/01 18:40:20, wkorman wrote:
> lgtm
> 
> https://codereview.chromium.org/2853083002/diff/1/build/vs_toolchain.py
> File build/vs_toolchain.py (right):
> 
>
https://codereview.chromium.org/2853083002/diff/1/build/vs_toolchain.py#newco...
> build/vs_toolchain.py:331: '10 SDK.' % full_path)
> Is there a page worth linking to directly? I found four from Google searching,
> with varying dead links, these look like the two that I might explore:
> 
> https://developer.microsoft.com/en-us/windows/hardware/windows-driver-kit
> https://developer.microsoft.com/en-us/windows/hardware/download-windbg
> 
> I realize the urls change often so maybe it's not worth including but thought
> worth brief discussion. Since I think the way I probably got into trouble is
> that one of the above is the right one, but even now I am not sure which.
> 
> And maybe VS 2017 even has an in-app checkbox that in theory installs the
thing,
> separate from above two urls/installers, but I am not sure that worked for me
> per previous bug discussion.

What did you search for? My intent was to encourage people to search for Windows
10 SDK, which takes me to the correct location as the first result:

https://developer.microsoft.com/en-us/windows/downloads/windows-10-sdk

VS 2017 does not, as far as I can tell, have an option to automatically install
the debuggers toolkit.

[wkorman, 2017-05-01 18:47:25]

On 2017/05/01 18:42:58, brucedawson wrote:
> On 2017/05/01 18:40:20, wkorman wrote:
> > lgtm
> > 
> > https://codereview.chromium.org/2853083002/diff/1/build/vs_toolchain.py
> > File build/vs_toolchain.py (right):
> > 
> >
>
https://codereview.chromium.org/2853083002/diff/1/build/vs_toolchain.py#newco...
> > build/vs_toolchain.py:331: '10 SDK.' % full_path)
> > Is there a page worth linking to directly? I found four from Google
searching,
> > with varying dead links, these look like the two that I might explore:
> > 
> > https://developer.microsoft.com/en-us/windows/hardware/windows-driver-kit
> > https://developer.microsoft.com/en-us/windows/hardware/download-windbg
> > 
> > I realize the urls change often so maybe it's not worth including but
thought
> > worth brief discussion. Since I think the way I probably got into trouble is
> > that one of the above is the right one, but even now I am not sure which.
> > 
> > And maybe VS 2017 even has an in-app checkbox that in theory installs the
> thing,
> > separate from above two urls/installers, but I am not sure that worked for
me
> > per previous bug discussion.
> 
> What did you search for? My intent was to encourage people to search for
Windows
> 10 SDK, which takes me to the correct location as the first result:
> 
> https://developer.microsoft.com/en-us/windows/downloads/windows-10-sdk
> 
> VS 2017 does not, as far as I can tell, have an option to automatically
install
> the debuggers toolkit.

I searched for "Debugging Tools for Windows windows 10 sdk".

I have vague recollection of VS 2017 having a "Win 10 SDK" checkbox, and/or a
debugger checkbox, and I thought one/both would install what I needed, and I
(again vaguely) remember it did create the relevant directory but it did not end
up containing the cdb.exe or needed dll.

Perhaps a more scalable solution would be to link to a chromium.org README.md
which we can keep up to date with link to the recommended Windows installers.
Maybe this file:

https://chromium.googlesource.com/chromium/src/+/master/docs/windows_build_in...

though it doesn't seem to mention anything about downloading/installing
something from MSFT currently.

[brucedawson, 2017-05-01 18:53:43]

On 2017/05/01 18:47:25, wkorman wrote:
> On 2017/05/01 18:42:58, brucedawson wrote:
> > On 2017/05/01 18:40:20, wkorman wrote:
> > > lgtm
> > > 
> > > https://codereview.chromium.org/2853083002/diff/1/build/vs_toolchain.py
> > > File build/vs_toolchain.py (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/2853083002/diff/1/build/vs_toolchain.py#newco...
> > > build/vs_toolchain.py:331: '10 SDK.' % full_path)
> > > Is there a page worth linking to directly? I found four from Google
> searching,
> > > with varying dead links, these look like the two that I might explore:
> > > 
> > > https://developer.microsoft.com/en-us/windows/hardware/windows-driver-kit
> > > https://developer.microsoft.com/en-us/windows/hardware/download-windbg
> > > 
> > > I realize the urls change often so maybe it's not worth including but
> thought
> > > worth brief discussion. Since I think the way I probably got into trouble
is
> > > that one of the above is the right one, but even now I am not sure which.
> > > 
> > > And maybe VS 2017 even has an in-app checkbox that in theory installs the
> > thing,
> > > separate from above two urls/installers, but I am not sure that worked for
> me
> > > per previous bug discussion.
> > 
> > What did you search for? My intent was to encourage people to search for
> Windows
> > 10 SDK, which takes me to the correct location as the first result:
> > 
> > https://developer.microsoft.com/en-us/windows/downloads/windows-10-sdk
> > 
> > VS 2017 does not, as far as I can tell, have an option to automatically
> install
> > the debuggers toolkit.
> 
> I searched for "Debugging Tools for Windows windows 10 sdk".
> 
> I have vague recollection of VS 2017 having a "Win 10 SDK" checkbox, and/or a
> debugger checkbox, and I thought one/both would install what I needed, and I
> (again vaguely) remember it did create the relevant directory but it did not
end
> up containing the cdb.exe or needed dll.
> 
> Perhaps a more scalable solution would be to link to a http://chromium.org
README.md
> which we can keep up to date with link to the recommended Windows installers.
> Maybe this file:
> 
>
https://chromium.googlesource.com/chromium/src/+/master/docs/windows_build_in...
> 
> though it doesn't seem to mention anything about downloading/installing
> something from MSFT currently.

This and the surrounding text is meant to imply that you need to install the
Windows 10 SDK: "The installer can be found in the Windows SDK archive." and
"When installing the 14393 Windows SDK choose Debugging Tools For Windows"

I agree it's not as clear as possible. Should I clean it up simultaneously?
Suggestions on what would make it better?

[commit-bot: I haz the power, 2017-05-01 19:41:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 19:41:33]

Dry run: This issue passed the CQ dry run.

[wkorman, 2017-05-01 19:56:49]

On 2017/05/01 18:53:43, brucedawson wrote:
> On 2017/05/01 18:47:25, wkorman wrote:
> > On 2017/05/01 18:42:58, brucedawson wrote:
> > > On 2017/05/01 18:40:20, wkorman wrote:
> > > > lgtm
> > > > 
> > > > https://codereview.chromium.org/2853083002/diff/1/build/vs_toolchain.py
> > > > File build/vs_toolchain.py (right):
> > > > 
> > > >
> > >
> >
>
https://codereview.chromium.org/2853083002/diff/1/build/vs_toolchain.py#newco...
> > > > build/vs_toolchain.py:331: '10 SDK.' % full_path)
> > > > Is there a page worth linking to directly? I found four from Google
> > searching,
> > > > with varying dead links, these look like the two that I might explore:
> > > > 
> > > >
https://developer.microsoft.com/en-us/windows/hardware/windows-driver-kit
> > > > https://developer.microsoft.com/en-us/windows/hardware/download-windbg
> > > > 
> > > > I realize the urls change often so maybe it's not worth including but
> > thought
> > > > worth brief discussion. Since I think the way I probably got into
trouble
> is
> > > > that one of the above is the right one, but even now I am not sure
which.
> > > > 
> > > > And maybe VS 2017 even has an in-app checkbox that in theory installs
the
> > > thing,
> > > > separate from above two urls/installers, but I am not sure that worked
for
> > me
> > > > per previous bug discussion.
> > > 
> > > What did you search for? My intent was to encourage people to search for
> > Windows
> > > 10 SDK, which takes me to the correct location as the first result:
> > > 
> > > https://developer.microsoft.com/en-us/windows/downloads/windows-10-sdk
> > > 
> > > VS 2017 does not, as far as I can tell, have an option to automatically
> > install
> > > the debuggers toolkit.
> > 
> > I searched for "Debugging Tools for Windows windows 10 sdk".
> > 
> > I have vague recollection of VS 2017 having a "Win 10 SDK" checkbox, and/or
a
> > debugger checkbox, and I thought one/both would install what I needed, and I
> > (again vaguely) remember it did create the relevant directory but it did not
> end
> > up containing the cdb.exe or needed dll.
> > 
> > Perhaps a more scalable solution would be to link to a http://chromium.org
> README.md
> > which we can keep up to date with link to the recommended Windows
installers.
> > Maybe this file:
> > 
> >
>
https://chromium.googlesource.com/chromium/src/+/master/docs/windows_build_in...
> > 
> > though it doesn't seem to mention anything about downloading/installing
> > something from MSFT currently.
> 
> This and the surrounding text is meant to imply that you need to install the
> Windows 10 SDK: "The installer can be found in the Windows SDK archive." and
> "When installing the 14393 Windows SDK choose Debugging Tools For Windows"
> 
> I agree it's not as clear as possible. Should I clean it up simultaneously?
> Suggestions on what would make it better?

Ah, I see that part now. I think the earlier version of that is what I had been
following.
I see you edited it here: https://codereview.chromium.org/2846643002

One thing perhaps worth noting is what we found in http://crbug.com/703005#c11
re: MSFT released multiple versions of 14393, and not all work out of the box.

I do still plan to go back to that bug and follow up on it.

Today the chromium.org doc links to here:

  https://developer.microsoft.com/en-us/windows/downloads/sdk-archive

but in the aforementioned bug you note:

  Microsoft says that the recommended version of 10.0.14393.0 is this one:

  https://developer.microsoft.com/en-us/windows/downloads/windows-10-sdk

Do the downloads at these two different pages produce the same result?

[brucedawson, 2017-05-01 20:16:49]

> > > Maybe this file:
>
https://chromium.googlesource.com/chromium/src/+/master/docs/windows_build_in...

Maybe, but we don't tend to have links in the error message, and that document
is fairly easily discoverable.

> One thing perhaps worth noting is what we found in http://crbug.com/703005#c11
> re: MSFT released multiple versions of 14393, and not all work out of the box.

Microsoft has released multiple versions of 14393, but they all should work. I
don't know what the uuid.lib problem is but I've installed many SDK versions and
never seen it. It's an open mystery.

> Today the http://chromium.org doc links to here:
> 
>   https://developer.microsoft.com/en-us/windows/downloads/sdk-archive
> 
> but in the aforementioned bug you note:
> 
>   Microsoft says that the recommended version of 10.0.14393.0 is this one:
> 
>   https://developer.microsoft.com/en-us/windows/downloads/windows-10-sdk
> 
> Do the downloads at these two different pages produce the same result?

Microsoft is not making this simple. The first link points to archived versions
- old versions of the SDK. Currently Chrome *requires* one of those archived
versions (one of the 14393 versions) because 15063 is broken - it has two
header-file bugs. I expect that they will get fixed at some point so I'm not
sure I want an error message to try to deal with all that mess.

Also, for perhaps of getting dbghelp.dll *any* version of the SDK will work. If
you don't have 14393 installed then you will hit a different set of failures.

I don't see any clean way of summarizing all this subtlety. For now any version
of dbghelp.dll will work, whether from the links you found or the other two.

[wkorman, 2017-05-01 20:20:21]

On 2017/05/01 20:16:49, brucedawson wrote:
> > > > Maybe this file:
> >
>
https://chromium.googlesource.com/chromium/src/+/master/docs/windows_build_in...
> 
> Maybe, but we don't tend to have links in the error message, and that document
> is fairly easily discoverable.
> 
> > One thing perhaps worth noting is what we found in
http://crbug.com/703005#c11
> > re: MSFT released multiple versions of 14393, and not all work out of the
box.
> 
> Microsoft has released multiple versions of 14393, but they all should work. I
> don't know what the uuid.lib problem is but I've installed many SDK versions
and
> never seen it. It's an open mystery.
> 
> > Today the http://chromium.org doc links to here:
> > 
> >   https://developer.microsoft.com/en-us/windows/downloads/sdk-archive
> > 
> > but in the aforementioned bug you note:
> > 
> >   Microsoft says that the recommended version of 10.0.14393.0 is this one:
> > 
> >   https://developer.microsoft.com/en-us/windows/downloads/windows-10-sdk
> > 
> > Do the downloads at these two different pages produce the same result?
> 
> Microsoft is not making this simple. The first link points to archived
versions
> - old versions of the SDK. Currently Chrome *requires* one of those archived
> versions (one of the 14393 versions) because 15063 is broken - it has two
> header-file bugs. I expect that they will get fixed at some point so I'm not
> sure I want an error message to try to deal with all that mess.
> 
> Also, for perhaps of getting dbghelp.dll *any* version of the SDK will work.
If
> you don't have 14393 installed then you will hit a different set of failures.
> 
> I don't see any clean way of summarizing all this subtlety. For now any
version
> of dbghelp.dll will work, whether from the links you found or the other two.

OK, I'm fine with it as is. When I go back to my home situation and try to get
it working again I'll follow up with any other detailed thoughts.

[brucedawson, 2017-05-01 20:21:53]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2017-05-01 20:22:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brucedawson, 2017-05-01 20:22:32]

> OK, I'm fine with it as is. When I go back to my home situation and try to get
> it working again I'll follow up with any other detailed thoughts.

Sounds good. I'll land it as is. I look forward to a fixed 15063 SDK so that we
can give simpler guidance.

[commit-bot: I haz the power, 2017-05-01 20:27:24]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493670113359600, "parent_rev":
"da4b99838d459396d412bc278358b7f335ac0fdc", "commit_rev":
"6c3d410ea272423ac277dc3f3e3def6490dfd6dc"}

[commit-bot: I haz the power, 2017-05-01 20:27:42]

Description was changed from

==========
Improve error message when debuggers not installed

When building Chrome we require that you have the "Debugging tools for
Windows" feature of the Windows 10 SDK installed. The error messages
when this non-default component is not installed are a bit cryptic. This
adds a more explicit error message.

The new error message looks like this:

>gn gen out\debug
Traceback (most recent call last):
  File "c:/src/chromium4/src/build/vs_toolchain.py", line 448, in <module>
    sys.exit(main())
  File "c:/src/chromium4/src/build/vs_toolchain.py", line 444, in main
    return commands[sys.argv[1]](*sys.argv[2:])
  File "c:/src/chromium4/src/build/vs_toolchain.py", line 309, in CopyDlls
    _CopyDebugger(target_dir, target_cpu)
  File "c:/src/chromium4/src/build/vs_toolchain.py", line 331, in _CopyDebugger
    '10 SDK.' % full_path)
Exception: dbghelp.dll not found in "C:\Program Files (x86)\Windows
Kits\10\Debuggers\x86\dbghelp.dll"
You must install the "Debugging Tools for Windows" feature from the Windows 10
SDK.
ERROR at //build/toolchain/win/BUILD.gn:39:3: Script returned non-zero exit
code.
  exec_script("../../vs_toolchain.py",
  ^----------
Current dir: c:/src/chromium4/src/out/debug/
Command: C:/src/depot_tools/python276_bin/python.exe --
c:/src/chromium4/src/build/vs_toolchain.py copy_dlls
c:/src/chromium4/src/out/debug Debug x86
Returned 1.
See //BUILD.gn:65:1: which caused the file to be included.
group("gn_all") {
^----------------

R=wkorman@chromium.org
BUG=702697
==========

to

==========
Improve error message when debuggers not installed

When building Chrome we require that you have the "Debugging tools for
Windows" feature of the Windows 10 SDK installed. The error messages
when this non-default component is not installed are a bit cryptic. This
adds a more explicit error message.

The new error message looks like this:

>gn gen out\debug
Traceback (most recent call last):
  File "c:/src/chromium4/src/build/vs_toolchain.py", line 448, in <module>
    sys.exit(main())
  File "c:/src/chromium4/src/build/vs_toolchain.py", line 444, in main
    return commands[sys.argv[1]](*sys.argv[2:])
  File "c:/src/chromium4/src/build/vs_toolchain.py", line 309, in CopyDlls
    _CopyDebugger(target_dir, target_cpu)
  File "c:/src/chromium4/src/build/vs_toolchain.py", line 331, in _CopyDebugger
    '10 SDK.' % full_path)
Exception: dbghelp.dll not found in "C:\Program Files (x86)\Windows
Kits\10\Debuggers\x86\dbghelp.dll"
You must install the "Debugging Tools for Windows" feature from the Windows 10
SDK.
ERROR at //build/toolchain/win/BUILD.gn:39:3: Script returned non-zero exit
code.
  exec_script("../../vs_toolchain.py",
  ^----------
Current dir: c:/src/chromium4/src/out/debug/
Command: C:/src/depot_tools/python276_bin/python.exe --
c:/src/chromium4/src/build/vs_toolchain.py copy_dlls
c:/src/chromium4/src/out/debug Debug x86
Returned 1.
See //BUILD.gn:65:1: which caused the file to be included.
group("gn_all") {
^----------------

R=wkorman@chromium.org
BUG=702697

Review-Url: https://codereview.chromium.org/2853083002
Cr-Commit-Position: refs/heads/master@{#468397}
Committed:
https://chromium.googlesource.com/chromium/src/+/6c3d410ea272423ac277dc3f3e3d...
==========

[commit-bot: I haz the power, 2017-05-01 20:27:43]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6c3d410ea272423ac277dc3f3e3d...