Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: build/vs_toolchain.py

Issue 2853083002: Improve error message when debuggers not installed (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright 2014 The Chromium Authors. All rights reserved. 2 # Copyright 2014 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 import glob 6 import glob
7 import json 7 import json
8 import os 8 import os
9 import pipes 9 import pipes
10 import platform 10 import platform
(...skipping 307 matching lines...) Expand 10 before | Expand all | Expand 10 after
318 from the SDK directory avoids using the system copy of dbghelp.dll which then 318 from the SDK directory avoids using the system copy of dbghelp.dll which then
319 ensures compatibility with recent debug information formats, such as VS 319 ensures compatibility with recent debug information formats, such as VS
320 2017 /debug:fastlink PDBs. 320 2017 /debug:fastlink PDBs.
321 """ 321 """
322 win_sdk_dir = SetEnvironmentAndGetSDKDir() 322 win_sdk_dir = SetEnvironmentAndGetSDKDir()
323 if not win_sdk_dir: 323 if not win_sdk_dir:
324 return 324 return
325 325
326 debug_file = 'dbghelp.dll' 326 debug_file = 'dbghelp.dll'
327 full_path = os.path.join(win_sdk_dir, 'Debuggers', target_cpu, debug_file) 327 full_path = os.path.join(win_sdk_dir, 'Debuggers', target_cpu, debug_file)
328 if not os.path.exists(full_path):
329 raise Exception('dbghelp.dll not found in "%s"\r\nYou must install the '
330 '"Debugging Tools for Windows" feature from the Windows '
331 '10 SDK.' % full_path)
wkorman 2017/05/01 18:40:19 Is there a page worth linking to directly? I found
328 target_path = os.path.join(target_dir, debug_file) 332 target_path = os.path.join(target_dir, debug_file)
329 _CopyRuntimeImpl(target_path, full_path) 333 _CopyRuntimeImpl(target_path, full_path)
330 334
331 335
332 def _GetDesiredVsToolchainHashes(): 336 def _GetDesiredVsToolchainHashes():
333 """Load a list of SHA1s corresponding to the toolchains that we want installed 337 """Load a list of SHA1s corresponding to the toolchains that we want installed
334 to build with.""" 338 to build with."""
335 env_version = GetVisualStudioVersion() 339 env_version = GetVisualStudioVersion()
336 if env_version == '2015': 340 if env_version == '2015':
337 # Update 3 final with patches with 10.0.14393.0 SDK. 341 # Update 3 final with patches with 10.0.14393.0 SDK.
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
435 'copy_dlls': CopyDlls, 439 'copy_dlls': CopyDlls,
436 } 440 }
437 if len(sys.argv) < 2 or sys.argv[1] not in commands: 441 if len(sys.argv) < 2 or sys.argv[1] not in commands:
438 print >>sys.stderr, 'Expected one of: %s' % ', '.join(commands) 442 print >>sys.stderr, 'Expected one of: %s' % ', '.join(commands)
439 return 1 443 return 1
440 return commands[sys.argv[1]](*sys.argv[2:]) 444 return commands[sys.argv[1]](*sys.argv[2:])
441 445
442 446
443 if __name__ == '__main__': 447 if __name__ == '__main__':
444 sys.exit(main()) 448 sys.exit(main())
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698