Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1000)

Issue 2846643002: Update Windows build instruction for 14393 SDK (Closed)

Created:
3 years, 8 months ago by brucedawson
Modified:
3 years, 8 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Windows build instruction for 14393 SDK The Windows build instructions mention that the 14393 SDK is needed but now that 15063 has shipped the SDK is harder to find, leading some developers to do problematic hacks. This adds a link to the archival installer. R=scottmg@chromium.org Review-Url: https://codereview.chromium.org/2846643002 Cr-Commit-Position: refs/heads/master@{#467512} Committed: https://chromium.googlesource.com/chromium/src/+/80610570ec4327389940e2ce084df9899692f42d

Patch Set 1 #

Total comments: 2

Patch Set 2 : Mentioned that 15063 is broken #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M docs/windows_build_instructions.md View 1 1 chunk +8 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
brucedawson
Clarify the build instructions by saying where to get the 14393 SDK. Some day Microsoft ...
3 years, 8 months ago (2017-04-26 22:30:41 UTC) #3
scottmg
lgtm https://codereview.chromium.org/2846643002/diff/1/docs/windows_build_instructions.md File docs/windows_build_instructions.md (right): https://codereview.chromium.org/2846643002/diff/1/docs/windows_build_instructions.md#newcode39 docs/windows_build_instructions.md:39: found in the [Windows SDK archive](https://developer.microsoft.com/en-us/windows/downloads/sdk-archive). Maybe say ...
3 years, 8 months ago (2017-04-26 23:06:30 UTC) #6
brucedawson
https://codereview.chromium.org/2846643002/diff/1/docs/windows_build_instructions.md File docs/windows_build_instructions.md (right): https://codereview.chromium.org/2846643002/diff/1/docs/windows_build_instructions.md#newcode39 docs/windows_build_instructions.md:39: found in the [Windows SDK archive](https://developer.microsoft.com/en-us/windows/downloads/sdk-archive). On 2017/04/26 23:06:30, ...
3 years, 8 months ago (2017-04-26 23:23:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2846643002/20001
3 years, 8 months ago (2017-04-26 23:25:24 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 23:39:55 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/80610570ec4327389940e2ce084d...

Powered by Google App Engine
This is Rietveld 408576698