[LayoutNG] Fix 'vertical-align' not to include metrics before alignment

[LayoutNG] Fix 'vertical-align' not to include metrics before alignment

This patch fixes not to include metrics before alignment when
'vertical-align' is one of values to be computed by ancestors; i.e.,
top, bottom, text-top, or text-bottom.

Also undoes a temporary fix introduced in CL[1].

[1] https://codereview.chromium.org/2840883002#msg14

BUG=636993
Review-Url: https://codereview.chromium.org/2852883003
Cr-Commit-Position: refs/heads/master@{#468559}
Committed: https://chromium.googlesource.com/chromium/src/+/c8a96c63d6eb03dbc39afc03fd22e7f19f36569a

[kojii, 2017-05-01 15:39:17]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 15:39:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-05-01 15:43:49]

Description was changed from

==========
ngvalign

BUG=
==========

to

==========
[LayoutNG] Fix 'vertical-align' may include metrics before aligned

This patch fixes not to include metrics before alignment when
'vertical-align' is one of values to be computed by ancestors; i.e.,
top, bottom, text-top, or text-bottom.

BUG=636993
==========

[kojii, 2017-05-01 15:46:38]

Description was changed from

==========
[LayoutNG] Fix 'vertical-align' may include metrics before aligned

This patch fixes not to include metrics before alignment when
'vertical-align' is one of values to be computed by ancestors; i.e.,
top, bottom, text-top, or text-bottom.

BUG=636993
==========

to

==========
[LayoutNG] Fix 'vertical-align' not to include metrics before aligned

This patch fixes not to include metrics before alignment when
'vertical-align' is one of values to be computed by ancestors; i.e.,
top, bottom, text-top, or text-bottom.

BUG=636993
==========

[kojii, 2017-05-01 15:50:36]

Description was changed from

==========
[LayoutNG] Fix 'vertical-align' not to include metrics before aligned

This patch fixes not to include metrics before alignment when
'vertical-align' is one of values to be computed by ancestors; i.e.,
top, bottom, text-top, or text-bottom.

BUG=636993
==========

to

==========
[LayoutNG] Fix 'vertical-align' not to include metrics before alignment

This patch fixes not to include metrics before alignment when
'vertical-align' is one of values to be computed by ancestors; i.e.,
top, bottom, text-top, or text-bottom.

BUG=636993
==========

[commit-bot: I haz the power, 2017-05-01 16:56:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 16:56:38]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kojii, 2017-05-01 18:18:27]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 18:19:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-05-01 18:22:56]

Description was changed from

==========
[LayoutNG] Fix 'vertical-align' not to include metrics before alignment

This patch fixes not to include metrics before alignment when
'vertical-align' is one of values to be computed by ancestors; i.e.,
top, bottom, text-top, or text-bottom.

BUG=636993
==========

to

==========
[LayoutNG] Fix 'vertical-align' not to include metrics before alignment

This patch fixes not to include metrics before alignment when
'vertical-align' is one of values to be computed by ancestors; i.e.,
top, bottom, text-top, or text-bottom.

Also undoes a hack introduced for a temporal fix[1].

[1] https://codereview.chromium.org/2840883002#msg14

BUG=636993
==========

[kojii, 2017-05-01 18:24:29]

Description was changed from

==========
[LayoutNG] Fix 'vertical-align' not to include metrics before alignment

This patch fixes not to include metrics before alignment when
'vertical-align' is one of values to be computed by ancestors; i.e.,
top, bottom, text-top, or text-bottom.

Also undoes a hack introduced for a temporal fix[1].

[1] https://codereview.chromium.org/2840883002#msg14

BUG=636993
==========

to

==========
[LayoutNG] Fix 'vertical-align' not to include metrics before alignment

This patch fixes not to include metrics before alignment when
'vertical-align' is one of values to be computed by ancestors; i.e.,
top, bottom, text-top, or text-bottom.

Also undoes a hack introduced for a temporaly fix[1].

[1] https://codereview.chromium.org/2840883002#msg14

BUG=636993
==========

[kojii, 2017-05-01 19:29:12]

kojii@chromium.org changed reviewers:
+ eae@chromium.org, glebl@chromium.org

[kojii, 2017-05-01 19:29:13]

PTAL.

[Gleb Lanbin, 2017-05-01 19:44:24]

lgtm

https://codereview.chromium.org/2852883003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/inline/ng_inline_box_state.cc
(right):

https://codereview.chromium.org/2852883003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/inline/ng_inline_box_state.cc:108: if
(!is_position_pending && box != stack_.begin()) {
.nit can we use a positive boolean statement here for the sake of readability?

if (is_position_pending || box == stack_.begin())
  return;

box[-1].metrics.Unite(box->metrics);

https://codereview.chromium.org/2852883003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/inline/ng_inline_box_state.cc:144:
return false;
.nit

const bool kPositionPending = true;
const bool kPositionNotPending = false;
...
...
if (vertical_align == EVerticalAlign::kBaseline)
  return kPositionNotPending;

...

https://codereview.chromium.org/2852883003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/inline/ng_inline_box_state.h
(right):

https://codereview.chromium.org/2852883003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/inline/ng_inline_box_state.h:85: //
@return true if the position is pending.
.nit
// @return Whether the position is pending.

https://codereview.chromium.org/2852883003/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm_test.cc
(right):

https://codereview.chromium.org/2852883003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm_test.cc:98:
inline_node->Layout(space.Get(), nullptr);
.nit

inline_node->Layout(space.Get(), /* break_token */ nullptr); 

or even better, make the second parameter optional, similar to  NGBlockNode
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/ng...

[Gleb Lanbin, 2017-05-01 19:44:28]

lgtm

[eae, 2017-05-01 20:10:18]

LGTM

[commit-bot: I haz the power, 2017-05-01 21:59:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 21:59:51]

Dry run: This issue passed the CQ dry run.

[kojii, 2017-05-02 02:51:06]

Description was changed from

==========
[LayoutNG] Fix 'vertical-align' not to include metrics before alignment

This patch fixes not to include metrics before alignment when
'vertical-align' is one of values to be computed by ancestors; i.e.,
top, bottom, text-top, or text-bottom.

Also undoes a hack introduced for a temporaly fix[1].

[1] https://codereview.chromium.org/2840883002#msg14

BUG=636993
==========

to

==========
[LayoutNG] Fix 'vertical-align' not to include metrics before alignment

This patch fixes not to include metrics before alignment when
'vertical-align' is one of values to be computed by ancestors; i.e.,
top, bottom, text-top, or text-bottom.

Also undoes a temporary fix introduced in CL[1].

[1] https://codereview.chromium.org/2840883002#msg14

BUG=636993
==========

[kojii, 2017-05-02 03:06:48]

nits all done, thank you for your prompt reviews!

[kojii, 2017-05-02 03:06:51]

The CQ bit was checked by kojii@chromium.org

[kojii, 2017-05-02 03:06:51]

The patchset sent to the CQ was uploaded after l-g-t-m from glebl@chromium.org,
eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2852883003/#ps60001
(title: "glebl nits")

[commit-bot: I haz the power, 2017-05-02 03:07:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 04:41:09]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493694411120550,
"parent_rev": "8dfce7635bf351e5ead9e6607bd068de121b1f92", "commit_rev":
"c8a96c63d6eb03dbc39afc03fd22e7f19f36569a"}

[commit-bot: I haz the power, 2017-05-02 04:41:44]

Description was changed from

==========
[LayoutNG] Fix 'vertical-align' not to include metrics before alignment

This patch fixes not to include metrics before alignment when
'vertical-align' is one of values to be computed by ancestors; i.e.,
top, bottom, text-top, or text-bottom.

Also undoes a temporary fix introduced in CL[1].

[1] https://codereview.chromium.org/2840883002#msg14

BUG=636993
==========

to

==========
[LayoutNG] Fix 'vertical-align' not to include metrics before alignment

This patch fixes not to include metrics before alignment when
'vertical-align' is one of values to be computed by ancestors; i.e.,
top, bottom, text-top, or text-bottom.

Also undoes a temporary fix introduced in CL[1].

[1] https://codereview.chromium.org/2840883002#msg14

BUG=636993

Review-Url: https://codereview.chromium.org/2852883003
Cr-Commit-Position: refs/heads/master@{#468559}
Committed:
https://chromium.googlesource.com/chromium/src/+/c8a96c63d6eb03dbc39afc03fd22...
==========

[commit-bot: I haz the power, 2017-05-02 04:41:45]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/c8a96c63d6eb03dbc39afc03fd22...