third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node.h - Issue 2852883003: [LayoutNG] Fix 'vertical-align' not to include metrics before alignment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node.h

Issue 2852883003: [LayoutNG] Fix 'vertical-align' not to include metrics before alignment (Closed)

Patch Set: glebl nits Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node.h

diff --git a/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node.h b/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node.h

index 366aeda434147663aab92faf7af7e0eb1ab57c17..9129873026086dece55c01273b92165879db0cc9 100644

--- a/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node.h

+++ b/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node.h

@@ -35,7 +35,8 @@ class CORE_EXPORT NGInlineNode : public NGLayoutInputNode {

const ComputedStyle& Style() const override { return block_->StyleRef(); }

NGLayoutInputNode* NextSibling() override;

- RefPtr<NGLayoutResult> Layout(NGConstraintSpace*, NGBreakToken*) override;

+ RefPtr<NGLayoutResult> Layout(NGConstraintSpace*,

+ NGBreakToken* = nullptr) override;

LayoutObject* GetLayoutObject() override;

// Computes the value of min-content and max-content for this anonymous block

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm_test.cc ('k') | no next file » | no next file with comments »