Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1212)

Unified Diff: third_party/WebKit/Source/core/layout/ng/inline/ng_inline_box_state.h

Issue 2852883003: [LayoutNG] Fix 'vertical-align' not to include metrics before alignment (Closed)
Patch Set: glebl nits Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/ng/inline/ng_inline_box_state.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/ng/inline/ng_inline_box_state.h
diff --git a/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_box_state.h b/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_box_state.h
index 9a52e3958134282a9056c8380491c9b242aa94b8..91bec14b30803a8e79dfe26052fb27dd4b44d07d 100644
--- a/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_box_state.h
+++ b/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_box_state.h
@@ -78,13 +78,16 @@ class NGInlineLayoutStateStack {
// end of a line.
void EndBoxState(NGInlineBoxState*, NGLineBoxFragmentBuilder*);
+ enum PositionPending { kPositionNotPending, kPositionPending };
+
// Compute vertical position for the 'vertical-align' property.
// The timing to apply varies by values; some values apply at the layout of
// the box was computed. Other values apply when the layout of the parent or
// the line box was computed.
// https://www.w3.org/TR/CSS22/visudet.html#propdef-vertical-align
// https://www.w3.org/TR/css-inline-3/#propdef-vertical-align
- void ApplyBaselineShift(NGInlineBoxState*, NGLineBoxFragmentBuilder*);
+ PositionPending ApplyBaselineShift(NGInlineBoxState*,
+ NGLineBoxFragmentBuilder*);
Vector<NGInlineBoxState, 4> stack_;
};
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/ng/inline/ng_inline_box_state.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698