Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2852633003: Compile scan_controller and gear_menu_controller in gyp v2 (Closed)

Created:
3 years, 7 months ago by oka
Modified:
3 years, 7 months ago
Reviewers:
fukino
CC:
chromium-reviews, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, jlklein+watch-closure_chromium.org, fukino+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Compile scan_controller and gear_menu_controller in gyp v2 TEST=run_compiler BUG=636289 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2852633003 Cr-Commit-Position: refs/heads/master@{#467926} Committed: https://chromium.googlesource.com/chromium/src/+/bc40747b23fee88ab7f819ae697268edf8b6b4ab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -13 lines) Patch
M ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp View 2 chunks +23 lines, -13 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
oka
PTAL.
3 years, 7 months ago (2017-04-28 05:43:06 UTC) #3
fukino
lgtm
3 years, 7 months ago (2017-04-28 05:47:24 UTC) #4
commit-bot: I haz the power
This CL has an open dependency (Issue 2846163002 Patch 20001). Please resolve the dependency and ...
3 years, 7 months ago (2017-04-28 06:13:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2852633003/1
3 years, 7 months ago (2017-04-28 06:23:25 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 07:59:21 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bc40747b23fee88ab7f819ae6972...

Powered by Google App Engine
This is Rietveld 408576698