Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1045)

Issue 2846783006: Compile import_controller in gyp v2 (Closed)

Created:
3 years, 7 months ago by oka
Modified:
3 years, 7 months ago
Reviewers:
fukino
CC:
chromium-reviews, tfarina, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, jlklein+watch-closure_chromium.org, fukino+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Compile import_controller in gyp v2 TEST=run_compiler BUG=636289 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2846783006 Cr-Commit-Position: refs/heads/master@{#468269} Committed: https://chromium.googlesource.com/chromium/src/+/303d2fcbe30651217015c0c7cfbfdb3fecf2a16a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -8 lines) Patch
M ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp View 1 chunk +22 lines, -4 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/import_controller.js View 1 chunk +4 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (5 generated)
oka
PTAL.
3 years, 7 months ago (2017-04-28 07:25:01 UTC) #3
fukino
lgtm
3 years, 7 months ago (2017-04-28 09:35:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2846783006/1
3 years, 7 months ago (2017-05-01 02:21:32 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 02:48:30 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/303d2fcbe30651217015c0c7cfbf...

Powered by Google App Engine
This is Rietveld 408576698