Compile file_manager_commands in gyp v2.

Compile file_manager_commands in gyp v2.

There were circular deps between file_manager_commands and file_manager.
This change removes dependency from file_manager_commands to
file_manager by extracting an interface from FileManager needed for
file_manager_commands to compile.
Also inlined some simple methods in FileManager, which are used
only from file_manager_commands.

BUG=636289
TEST=run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2846163002
Cr-Commit-Position: refs/heads/master@{#467917}
Committed: https://chromium.googlesource.com/chromium/src/+/f37aa1b929a74c74350f866e1a2658219a591b5b

[oka, 2017-04-28 02:01:35]

Description was changed from

==========
Compile file_manager_commands in gyp v2.

BUG=636289
TEST=run_compiler
==========

to

==========
Compile file_manager_commands in gyp v2.

BUG=636289
TEST=run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[oka, 2017-04-28 02:35:18]

Description was changed from

==========
Compile file_manager_commands in gyp v2.

BUG=636289
TEST=run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Compile file_manager_commands in gyp v2.

There were circule deps between file_manager_commands and file_manager.
This change removes dependency from file_manager_commands to
file_manager by extracting an interface from FileManager needed for
file_manager_commands to compile.
Also inlined some simple methods in FileManager, which are used
only from file_manager_commands.

BUG=636289
TEST=run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[oka, 2017-04-28 02:36:30]

.

[oka, 2017-04-28 02:36:57]

The CQ bit was checked by oka@chromium.org to run a CQ dry run

[oka, 2017-04-28 02:37:10]

oka@chromium.org changed reviewers:
+ fukino@chromium.org

[oka, 2017-04-28 02:37:11]

PTAL.

[commit-bot: I haz the power, 2017-04-28 02:37:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 04:39:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 04:39:24]

Dry run: This issue passed the CQ dry run.

[fukino, 2017-04-28 04:54:04]

LGTM. Thanks!

[oka, 2017-04-28 05:03:12]

Description was changed from

==========
Compile file_manager_commands in gyp v2.

There were circule deps between file_manager_commands and file_manager.
This change removes dependency from file_manager_commands to
file_manager by extracting an interface from FileManager needed for
file_manager_commands to compile.
Also inlined some simple methods in FileManager, which are used
only from file_manager_commands.

BUG=636289
TEST=run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Compile file_manager_commands in gyp v2.

There were circular deps between file_manager_commands and file_manager.
This change removes dependency from file_manager_commands to
file_manager by extracting an interface from FileManager needed for
file_manager_commands to compile.
Also inlined some simple methods in FileManager, which are used
only from file_manager_commands.

BUG=636289
TEST=run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[oka, 2017-04-28 05:03:31]

The CQ bit was checked by oka@chromium.org

[commit-bot: I haz the power, 2017-04-28 05:04:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 05:04:07]

This CL has an open dependency (Issue 2830223003 Patch 220001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[oka, 2017-04-28 06:13:35]

The CQ bit was checked by oka@chromium.org

[commit-bot: I haz the power, 2017-04-28 06:13:47]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 06:17:43]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493360015658280,
"parent_rev": "6c540a0cf80885708e1b5bb5f9c2c04082e6b0c1", "commit_rev":
"f37aa1b929a74c74350f866e1a2658219a591b5b"}

[commit-bot: I haz the power, 2017-04-28 06:17:52]

Description was changed from

==========
Compile file_manager_commands in gyp v2.

There were circular deps between file_manager_commands and file_manager.
This change removes dependency from file_manager_commands to
file_manager by extracting an interface from FileManager needed for
file_manager_commands to compile.
Also inlined some simple methods in FileManager, which are used
only from file_manager_commands.

BUG=636289
TEST=run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Compile file_manager_commands in gyp v2.

There were circular deps between file_manager_commands and file_manager.
This change removes dependency from file_manager_commands to
file_manager by extracting an interface from FileManager needed for
file_manager_commands to compile.
Also inlined some simple methods in FileManager, which are used
only from file_manager_commands.

BUG=636289
TEST=run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2846163002
Cr-Commit-Position: refs/heads/master@{#467917}
Committed:
https://chromium.googlesource.com/chromium/src/+/f37aa1b929a74c74350f866e1a26...
==========

[commit-bot: I haz the power, 2017-04-28 06:17:56]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f37aa1b929a74c74350f866e1a26...