Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 285233010: Decouple CpuFeatures from serializer state. (Closed)

Created:
6 years, 7 months ago by Yang
Modified:
6 years, 7 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Decouple CpuFeatures from serializer state. Traditionally, we cross compile a snapshot iff the serializer is enabled. This will change in the future. Changes: - CpuFeatures probing is done once per process, depending on whether we cross compile. - CpuFeatures are consolidated into the platform-independent assembler.h as much as possible. - FLAG_enable_<feature> will only be checked at probing time (already the case for ARM). - The serializer state is cached by the MacroAssembler. - PlatformFeatureScope is no longer necessary. - CPUFeature enum values no longer map to CPUID bit fields. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21347

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+300 lines, -802 lines) Patch
M src/arm/assembler-arm.h View 2 chunks +2 lines, -69 lines 0 comments Download
M src/arm/assembler-arm.cc View 14 chunks +62 lines, -135 lines 0 comments Download
M src/arm/assembler-arm-inl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/macro-assembler-arm.cc View 7 chunks +9 lines, -13 lines 0 comments Download
M src/arm64/assembler-arm64.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/arm64/assembler-arm64.cc View 10 chunks +29 lines, -16 lines 0 comments Download
M src/arm64/assembler-arm64-inl.h View 1 chunk +3 lines, -0 lines 0 comments Download
D src/arm64/cpu-arm64.h View 1 chunk +0 lines, -74 lines 0 comments Download
M src/arm64/cpu-arm64.cc View 2 chunks +1 line, -37 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M src/assembler.h View 3 chunks +41 lines, -7 lines 0 comments Download
M src/assembler.cc View 4 chunks +12 lines, -19 lines 0 comments Download
M src/code-stubs.h View 7 chunks +1 line, -15 lines 0 comments Download
M src/code-stubs.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M src/flags.h View 2 chunks +1 line, -6 lines 0 comments Download
M src/flags.cc View 3 chunks +2 lines, -13 lines 0 comments Download
M src/full-codegen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/assembler-ia32.h View 1 chunk +0 lines, -67 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 2 chunks +15 lines, -43 lines 0 comments Download
M src/ia32/assembler-ia32-inl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/stub-cache-ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/mips/assembler-mips.h View 1 chunk +0 lines, -59 lines 0 comments Download
M src/mips/assembler-mips.cc View 3 chunks +22 lines, -52 lines 0 comments Download
M src/mips/assembler-mips-inl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mksnapshot.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M src/platform.h View 1 chunk +1 line, -1 line 0 comments Download
M src/platform-posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/platform-win32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/v8.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/v8globals.h View 1 chunk +20 lines, -14 lines 0 comments Download
M src/x64/assembler-x64.h View 1 chunk +0 lines, -67 lines 0 comments Download
M src/x64/assembler-x64.cc View 3 chunks +18 lines, -48 lines 0 comments Download
M src/x64/assembler-x64-inl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/macro-assembler-x64.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M test/cctest/test-assembler-x64.cc View 14 chunks +14 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 7 months ago (2014-05-16 09:44:46 UTC) #1
Sven Panne
lgtm
6 years, 7 months ago (2014-05-16 10:41:50 UTC) #2
Yang
6 years, 7 months ago (2014-05-16 15:19:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21347 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698