Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: src/code-stubs.h

Issue 285233010: Decouple CpuFeatures from serializer state. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/assembler.cc ('k') | src/code-stubs.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-stubs.h
diff --git a/src/code-stubs.h b/src/code-stubs.h
index 4180e27da0a4f3189e6b6bccb13857903d25c204..fbd0c2bca79a2a42a210a589389e13af154c6a0c 100644
--- a/src/code-stubs.h
+++ b/src/code-stubs.h
@@ -194,8 +194,6 @@ class CodeStub BASE_EMBEDDED {
// Generates the assembler code for the stub.
virtual Handle<Code> GenerateCode() = 0;
- virtual void VerifyPlatformFeatures();
-
// Returns whether the code generated for this stub needs to be allocated as
// a fixed (non-moveable) code object.
virtual bool NeedsImmovableCode() { return false; }
@@ -1130,8 +1128,6 @@ class BinaryOpICStub : public HydrogenCodeStub {
return state_.GetExtraICState();
}
- virtual void VerifyPlatformFeatures() V8_FINAL V8_OVERRIDE { }
-
virtual Handle<Code> GenerateCode() V8_OVERRIDE;
const BinaryOpIC::State& state() const { return state_; }
@@ -1185,8 +1181,6 @@ class BinaryOpICWithAllocationSiteStub V8_FINAL : public PlatformCodeStub {
return state_.GetExtraICState();
}
- virtual void VerifyPlatformFeatures() V8_OVERRIDE { }
-
virtual void Generate(MacroAssembler* masm) V8_OVERRIDE;
virtual void PrintState(StringStream* stream) V8_OVERRIDE;
@@ -1266,8 +1260,6 @@ class StringAddStub V8_FINAL : public HydrogenCodeStub {
return PretenureFlagBits::decode(bit_field_);
}
- virtual void VerifyPlatformFeatures() V8_OVERRIDE { }
-
virtual Handle<Code> GenerateCode() V8_OVERRIDE;
virtual void InitializeInterfaceDescriptor(
@@ -1477,9 +1469,6 @@ class CEntryStub : public PlatformCodeStub {
// can generate both variants ahead of time.
static void GenerateAheadOfTime(Isolate* isolate);
- protected:
- virtual void VerifyPlatformFeatures() V8_OVERRIDE { }
-
private:
// Number of pointers/values returned.
const int result_size_;
@@ -1874,7 +1863,7 @@ class DoubleToIStub : public PlatformCodeStub {
OffsetBits::encode(offset) |
IsTruncatingBits::encode(is_truncating) |
SkipFastPathBits::encode(skip_fastpath) |
- SSE3Bits::encode(CpuFeatures::IsSafeForSnapshot(isolate, SSE3) ? 1 : 0);
+ SSE3Bits::encode(CpuFeatures::IsSupported(SSE3) ? 1 : 0);
}
Register source() {
@@ -1901,9 +1890,6 @@ class DoubleToIStub : public PlatformCodeStub {
virtual bool SometimesSetsUpAFrame() { return false; }
- protected:
- virtual void VerifyPlatformFeatures() V8_OVERRIDE { }
-
private:
static const int kBitsPerRegisterNumber = 6;
STATIC_ASSERT((1L << kBitsPerRegisterNumber) >= Register::kNumRegisters);
« no previous file with comments | « src/assembler.cc ('k') | src/code-stubs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698