Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: src/arm64/cpu-arm64.cc

Issue 285233010: Decouple CpuFeatures from serializer state. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/arm64/cpu-arm64.h ('k') | src/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/arm64/cpu-arm64.cc
diff --git a/src/arm64/cpu-arm64.cc b/src/arm64/cpu-arm64.cc
index a96a7b15b1e7f2818eb8ed77bf2887397f104c09..5484306ebfc0c68b56265e3f7428e572fee7a754 100644
--- a/src/arm64/cpu-arm64.cc
+++ b/src/arm64/cpu-arm64.cc
@@ -8,20 +8,12 @@
#if V8_TARGET_ARCH_ARM64
-#include "arm64/cpu-arm64.h"
+#include "cpu.h"
#include "arm64/utils-arm64.h"
namespace v8 {
namespace internal {
-#ifdef DEBUG
-bool CpuFeatures::initialized_ = false;
-#endif
-unsigned CpuFeatures::supported_ = 0;
-unsigned CpuFeatures::found_by_runtime_probing_only_ = 0;
-unsigned CpuFeatures::cross_compile_ = 0;
-
-
class CacheLineSizes {
public:
CacheLineSizes() {
@@ -126,34 +118,6 @@ void CPU::FlushICache(void* address, size_t length) {
#endif
}
-
-void CpuFeatures::Probe(bool serializer_enabled) {
- ASSERT(supported_ == 0);
-
- if (serializer_enabled && FLAG_enable_always_align_csp) {
- // Always align csp in snapshot code - this is safe and ensures that csp
- // will always be aligned if it is enabled by probing at runtime.
- supported_ |= static_cast<uint64_t>(1) << ALWAYS_ALIGN_CSP;
- }
-
- if (!serializer_enabled) {
- CPU cpu;
- // Always align csp on Nvidia cores or when debug_code is enabled.
- if (FLAG_enable_always_align_csp &&
- (cpu.implementer() == CPU::NVIDIA || FLAG_debug_code)) {
- found_by_runtime_probing_only_ |=
- static_cast<uint64_t>(1) << ALWAYS_ALIGN_CSP;
- }
-
- supported_ |= found_by_runtime_probing_only_;
- }
-
-#ifdef DEBUG
- initialized_ = true;
-#endif
-}
-
-
} } // namespace v8::internal
#endif // V8_TARGET_ARCH_ARM64
« no previous file with comments | « src/arm64/cpu-arm64.h ('k') | src/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698