Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1157)

Unified Diff: src/v8globals.h

Issue 285233010: Decouple CpuFeatures from serializer state. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/v8.cc ('k') | src/x64/assembler-x64.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/v8globals.h
diff --git a/src/v8globals.h b/src/v8globals.h
index 3f4d83103b3716c30c0167ed83338538e62e2dff..7ca939977b027b0de56bfefb9fb672c5bcaec903 100644
--- a/src/v8globals.h
+++ b/src/v8globals.h
@@ -399,20 +399,26 @@ enum StateTag {
#endif
-// Feature flags bit positions. They are mostly based on the CPUID spec.
-// On X86/X64, values below 32 are bits in EDX, values above 32 are bits in ECX.
-enum CpuFeature { SSE4_1 = 32 + 19, // x86
- SSE3 = 32 + 0, // x86
- VFP3 = 1, // ARM
- ARMv7 = 2, // ARM
- SUDIV = 3, // ARM
- UNALIGNED_ACCESSES = 4, // ARM
- MOVW_MOVT_IMMEDIATE_LOADS = 5, // ARM
- VFP32DREGS = 6, // ARM
- NEON = 7, // ARM
- SAHF = 0, // x86
- FPU = 1, // MIPS
- ALWAYS_ALIGN_CSP = 1 }; // ARM64
+// CPU feature flags.
+enum CpuFeature {
+ // x86
+ SSE4_1,
+ SSE3,
+ SAHF,
+ // ARM
+ VFP3,
+ ARMv7,
+ SUDIV,
+ UNALIGNED_ACCESSES,
+ MOVW_MOVT_IMMEDIATE_LOADS,
+ VFP32DREGS,
+ NEON,
+ // MIPS
+ FPU,
+ // ARM64
+ ALWAYS_ALIGN_CSP,
+ NUMBER_OF_CPU_FEATURES
+};
// Used to specify if a macro instruction must perform a smi check on tagged
« no previous file with comments | « src/v8.cc ('k') | src/x64/assembler-x64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698