Break dependency between ChromeClient and WebViewImpl, and ChromeClientImpl.

Break dependency between ChromeClient and WebViewImpl, and ChromeClientImpl.

ChromeClientImpl implements core/page/ChromeClient (not public), and only one
method in ChromeClientImpl was missing from ChromeClient. This CL makes the
missing method pure virtual in ChromeClient and overrides it in ChromeClientImpl
and then changes WebViewImpl to return a ChromeClient reference rather than
a ChromeClientImpl reference.

Next we can remove direct references of ChromeClientImpl in other web/* classes.

BUG=712963
Review-Url: https://codereview.chromium.org/2852013002
Cr-Commit-Position: refs/heads/master@{#468527}
Committed: https://chromium.googlesource.com/chromium/src/+/57278545b2bb8e4d6b5ca3d241852bc346933d4e

[slangley, 2017-05-01 04:00:18]

Description was changed from

==========
Break dependency between ChromeClient and WebViewImpl, and ChromeClientImpl.

ChromeClientImpl implements core/page/ChromeClient (not public), and only one
method in ChromeClientImpl was missing from ChromeClient. This CL makes the
missing method pure virtual in ChromeClient and overrides it in ChromeClientImpl
and then changes WebViewImpl to return a ChromeClient reference rather than
a ChromeClientImpl reference.

BUG=
==========

to

==========
Break dependency between ChromeClient and WebViewImpl, and ChromeClientImpl.

ChromeClientImpl implements core/page/ChromeClient (not public), and only one
method in ChromeClientImpl was missing from ChromeClient. This CL makes the
missing method pure virtual in ChromeClient and overrides it in ChromeClientImpl
and then changes WebViewImpl to return a ChromeClient reference rather than
a ChromeClientImpl reference.

Next we can remove direct references of ChromeClientImpl in other web/* classes.

BUG=712963
==========

[slangley, 2017-05-01 04:00:40]

slangley@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2017-05-01 07:27:43]

LGTM

[slangley, 2017-05-01 21:49:37]

The CQ bit was checked by slangley@chromium.org

[commit-bot: I haz the power, 2017-05-01 21:50:26]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 01:34:11]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493675377529230, "parent_rev":
"740768575325237705b0249460683fcf692bbd1e", "commit_rev":
"57278545b2bb8e4d6b5ca3d241852bc346933d4e"}

[commit-bot: I haz the power, 2017-05-02 01:34:23]

Description was changed from

==========
Break dependency between ChromeClient and WebViewImpl, and ChromeClientImpl.

ChromeClientImpl implements core/page/ChromeClient (not public), and only one
method in ChromeClientImpl was missing from ChromeClient. This CL makes the
missing method pure virtual in ChromeClient and overrides it in ChromeClientImpl
and then changes WebViewImpl to return a ChromeClient reference rather than
a ChromeClientImpl reference.

Next we can remove direct references of ChromeClientImpl in other web/* classes.

BUG=712963
==========

to

==========
Break dependency between ChromeClient and WebViewImpl, and ChromeClientImpl.

ChromeClientImpl implements core/page/ChromeClient (not public), and only one
method in ChromeClientImpl was missing from ChromeClient. This CL makes the
missing method pure virtual in ChromeClient and overrides it in ChromeClientImpl
and then changes WebViewImpl to return a ChromeClient reference rather than
a ChromeClientImpl reference.

Next we can remove direct references of ChromeClientImpl in other web/* classes.

BUG=712963

Review-Url: https://codereview.chromium.org/2852013002
Cr-Commit-Position: refs/heads/master@{#468527}
Committed:
https://chromium.googlesource.com/chromium/src/+/57278545b2bb8e4d6b5ca3d24185...
==========

[commit-bot: I haz the power, 2017-05-02 01:34:24]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/57278545b2bb8e4d6b5ca3d24185...