Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Side by Side Diff: third_party/WebKit/Source/web/WebViewImpl.h

Issue 2852013002: Break dependency between ChromeClient and WebViewImpl, and ChromeClientImpl. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/web/ChromeClientImpl.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 476 matching lines...) Expand 10 before | Expand all | Expand 10 after
487 WebDisplayMode DisplayMode() const override { return display_mode_; } 487 WebDisplayMode DisplayMode() const override { return display_mode_; }
488 488
489 PageScaleConstraintsSet& GetPageScaleConstraintsSet() const override; 489 PageScaleConstraintsSet& GetPageScaleConstraintsSet() const override;
490 490
491 FloatSize ElasticOverscroll() const override { return elastic_overscroll_; } 491 FloatSize ElasticOverscroll() const override { return elastic_overscroll_; }
492 492
493 double LastFrameTimeMonotonic() const override { 493 double LastFrameTimeMonotonic() const override {
494 return last_frame_time_monotonic_; 494 return last_frame_time_monotonic_;
495 } 495 }
496 496
497 ChromeClientImpl& ChromeClient() const { return *chrome_client_impl_.Get(); } 497 class ChromeClient& ChromeClient() const override {
498 return *chrome_client_impl_.Get();
499 }
498 500
499 // Returns the currently active WebInputMethodController which is the one 501 // Returns the currently active WebInputMethodController which is the one
500 // corresponding to the focused frame. It will return nullptr if there is no 502 // corresponding to the focused frame. It will return nullptr if there is no
501 // focused frame, or if the there is one but it belongs to a different local 503 // focused frame, or if the there is one but it belongs to a different local
502 // root. 504 // root.
503 WebInputMethodControllerImpl* GetActiveWebInputMethodController() const; 505 WebInputMethodControllerImpl* GetActiveWebInputMethodController() const;
504 506
505 void SetLastHiddenPagePopup(WebPagePopupImpl* page_popup) override { 507 void SetLastHiddenPagePopup(WebPagePopupImpl* page_popup) override {
506 last_hidden_page_popup_ = page_popup; 508 last_hidden_page_popup_ = page_popup;
507 } 509 }
(...skipping 237 matching lines...) Expand 10 before | Expand all | Expand 10 after
745 Persistent<ResizeViewportAnchor> resize_viewport_anchor_; 747 Persistent<ResizeViewportAnchor> resize_viewport_anchor_;
746 }; 748 };
747 749
748 // We have no ways to check if the specified WebView is an instance of 750 // We have no ways to check if the specified WebView is an instance of
749 // WebViewImpl because WebViewImpl is the only implementation of WebView. 751 // WebViewImpl because WebViewImpl is the only implementation of WebView.
750 DEFINE_TYPE_CASTS(WebViewImpl, WebView, webView, true, true); 752 DEFINE_TYPE_CASTS(WebViewImpl, WebView, webView, true, true);
751 753
752 } // namespace blink 754 } // namespace blink
753 755
754 #endif 756 #endif
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/ChromeClientImpl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698