third_party/WebKit/Source/web/ChromeClientImpl.h - Issue 2852013002: Break dependency between ChromeClient and WebViewImpl, and ChromeClientImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ChromeClientImpl.h

Issue 2852013002: Break dependency between ChromeClient and WebViewImpl, and ChromeClientImpl. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/ChromeClientImpl.h

diff --git a/third_party/WebKit/Source/web/ChromeClientImpl.h b/third_party/WebKit/Source/web/ChromeClientImpl.h

index 063f72b2cdc5c6dd9a828fcfd0fe7d2fc8debe83..0b2722a4425c2a052c8ac058800c86040466d647 100644

--- a/third_party/WebKit/Source/web/ChromeClientImpl.h

+++ b/third_party/WebKit/Source/web/ChromeClientImpl.h

@@ -229,7 +229,7 @@ class WEB_EXPORT ChromeClientImpl final : public ChromeClient {

void RegisterPopupOpeningObserver(PopupOpeningObserver*) override;

void UnregisterPopupOpeningObserver(PopupOpeningObserver*) override;

- void NotifyPopupOpeningObservers() const;

+ void NotifyPopupOpeningObservers() const override;

void InstallSupplements(LocalFrame&) override;