Create GoogleURLTrackerClient interface and //chrome implementation

Create GoogleURLTrackerClient interface and //chrome implementation

GoogleURLTrackerClient is the interface via which GoogleURLTracker will talk to
its embedder. This CL creates that interface as well as
ChromeGoogleURLTrackerClient, the //chrome implementation. The interface and
implementation are carved out of GoogleURLTrackerNavigationTracker(Impl),
specifically the parts that are not per-tab. A followup CL will modify
GoogleURLTrackerNavigationTracker to the driver interface for
GoogleURLTracker.

BUG=373220
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271638

[Peter Kasting, 2014-05-14 23:30:27]

https://codereview.chromium.org/285193002/diff/20001/chrome/browser/google/ch...
File chrome/browser/google/chrome_google_url_tracker_client.cc (right):

https://codereview.chromium.org/285193002/diff/20001/chrome/browser/google/ch...
chrome/browser/google/chrome_google_url_tracker_client.cc:16:
ChromeGoogleURLTrackerClient() : tracker_(NULL) {
Nit: Linebreak not necessary (everything will fit in 80 columns)

https://codereview.chromium.org/285193002/diff/20001/chrome/browser/google/ch...
chrome/browser/google/chrome_google_url_tracker_client.cc:20:
~ChromeGoogleURLTrackerClient() {
Nit: Linebreak not necessary

https://codereview.chromium.org/285193002/diff/20001/chrome/browser/google/ch...
chrome/browser/google/chrome_google_url_tracker_client.cc:49: switch (type) {
Nit: Simpler:

  DCHECK_EQ(content::NOTIFICATION_NAV_ENTRY_PENDING, type);
  ... handler code

https://codereview.chromium.org/285193002/diff/20001/chrome/browser/google/ch...
File chrome/browser/google/chrome_google_url_tracker_client.h (right):

https://codereview.chromium.org/285193002/diff/20001/chrome/browser/google/ch...
chrome/browser/google/chrome_google_url_tracker_client.h:14: public
content::NotificationObserver {
Nit: Wrap like:

class ChromeGoogleURLTrackerClient : public GoogleURLTrackerClient,
                                     public content::NotificationObserver {

https://codereview.chromium.org/285193002/diff/20001/chrome/browser/google/ch...
chrome/browser/google/chrome_google_url_tracker_client.h:19: //
GoogleURLTrackerClient.
Nit: There's no rule about this, but the most common way to comment such blocks
uses a trailing colon instead of a period.  Since you do that below, probably
better to be consistent here.

https://codereview.chromium.org/285193002/diff/20001/chrome/browser/google/ch...
chrome/browser/google/chrome_google_url_tracker_client.h:32: };
Nit: DISALLOW_COPY_AND_ASSIGN

https://codereview.chromium.org/285193002/diff/20001/chrome/browser/google/go...
File chrome/browser/google/google_url_tracker.cc (right):

https://codereview.chromium.org/285193002/diff/20001/chrome/browser/google/go...
chrome/browser/google/google_url_tracker.cc:211:
weak_ptr_factory_.InvalidateWeakPtrs();
Why are the four lines above necessary?

https://codereview.chromium.org/285193002/diff/20001/chrome/browser/google/go...
File chrome/browser/google/google_url_tracker_unittest.cc (right):

https://codereview.chromium.org/285193002/diff/20001/chrome/browser/google/go...
chrome/browser/google/google_url_tracker_unittest.cc:98: //
TestGoogleURLTrackerClient -------------------------------------
Tiny nit: Can you make all the lines of dashes in this file go out to 79 chars
like the first two lines (above) do?

https://codereview.chromium.org/285193002/diff/20001/chrome/browser/google/go...
chrome/browser/google/google_url_tracker_unittest.cc:101: : public
GoogleURLTrackerClient {
Nit: Linebreak not necessary

https://codereview.chromium.org/285193002/diff/20001/chrome/browser/google/go...
chrome/browser/google/google_url_tracker_unittest.cc:113: };
Nit: DISALLOW_COPY_AND_ASSIGN

https://codereview.chromium.org/285193002/diff/20001/chrome/browser/google/go...
chrome/browser/google/google_url_tracker_unittest.cc:121:
~TestGoogleURLTrackerClient() {
Nit: Linebreak not necessary

https://codereview.chromium.org/285193002/diff/20001/chrome/browser/google/go...
chrome/browser/google/google_url_tracker_unittest.cc:126: tracker_ = tracker;
Since both GoogleURLTrackerClient implementations seem to want to do this, maybe
the base class should have a GoogleURLTracker* member, and define a non-virtual
cheap public setter ("void set_google_url_tracker(GoogleURLTracker*
google_url_tracker);") as well as a protected getter ("GoogleURLTracker*
google_url_tracker();") for the implementations to use.

I realize this will make the base class non-pure, but I don't think that's a
problem.  If being able to refer to the owning tracker is a core concept that
GoogleURLTrackerClients need to do, it makes sense to go ahead and put that
concrete implementation in the base class.

https://codereview.chromium.org/285193002/diff/20001/chrome/browser/google/go...
chrome/browser/google/google_url_tracker_unittest.cc:343:
network_change_notifier_.reset();
Why are any of these four lines necessary?

https://codereview.chromium.org/285193002/diff/20001/components/google/core/b...
File components/google/core/browser/google_url_tracker_client.h (right):

https://codereview.chromium.org/285193002/diff/20001/components/google/core/b...
components/google/core/browser/google_url_tracker_client.h:10: // Interface via
which GoogleURLTracker communicates with its embedder.
Nit: via -> by

[blundell, 2014-05-15 07:58:02]

Thanks!

https://codereview.chromium.org/285193002/diff/20001/chrome/browser/google/ch...
File chrome/browser/google/chrome_google_url_tracker_client.cc (right):

https://codereview.chromium.org/285193002/diff/20001/chrome/browser/google/ch...
chrome/browser/google/chrome_google_url_tracker_client.cc:16:
ChromeGoogleURLTrackerClient() : tracker_(NULL) {
On 2014/05/14 23:30:28, Peter Kasting wrote:
> Nit: Linebreak not necessary (everything will fit in 80 columns)

Done.

https://codereview.chromium.org/285193002/diff/20001/chrome/browser/google/ch...
chrome/browser/google/chrome_google_url_tracker_client.cc:20:
~ChromeGoogleURLTrackerClient() {
On 2014/05/14 23:30:28, Peter Kasting wrote:
> Nit: Linebreak not necessary

Done.

https://codereview.chromium.org/285193002/diff/20001/chrome/browser/google/ch...
chrome/browser/google/chrome_google_url_tracker_client.cc:49: switch (type) {
On 2014/05/14 23:30:28, Peter Kasting wrote:
> Nit: Simpler:
> 
>   DCHECK_EQ(content::NOTIFICATION_NAV_ENTRY_PENDING, type);
>   ... handler code

Done.

https://codereview.chromium.org/285193002/diff/20001/chrome/browser/google/ch...
File chrome/browser/google/chrome_google_url_tracker_client.h (right):

https://codereview.chromium.org/285193002/diff/20001/chrome/browser/google/ch...
chrome/browser/google/chrome_google_url_tracker_client.h:14: public
content::NotificationObserver {
On 2014/05/14 23:30:28, Peter Kasting wrote:
> Nit: Wrap like:
> 
> class ChromeGoogleURLTrackerClient : public GoogleURLTrackerClient,
>                                      public content::NotificationObserver {

Done.

https://codereview.chromium.org/285193002/diff/20001/chrome/browser/google/ch...
chrome/browser/google/chrome_google_url_tracker_client.h:19: //
GoogleURLTrackerClient.
On 2014/05/14 23:30:28, Peter Kasting wrote:
> Nit: There's no rule about this, but the most common way to comment such
blocks
> uses a trailing colon instead of a period.  Since you do that below, probably
> better to be consistent here.

Done.

https://codereview.chromium.org/285193002/diff/20001/chrome/browser/google/ch...
chrome/browser/google/chrome_google_url_tracker_client.h:32: };
On 2014/05/14 23:30:28, Peter Kasting wrote:
> Nit: DISALLOW_COPY_AND_ASSIGN

Done.

https://codereview.chromium.org/285193002/diff/20001/chrome/browser/google/go...
File chrome/browser/google/google_url_tracker.cc (right):

https://codereview.chromium.org/285193002/diff/20001/chrome/browser/google/go...
chrome/browser/google/google_url_tracker.cc:211:
weak_ptr_factory_.InvalidateWeakPtrs();
I'm not familiar with this code. For KeyedServices, the general pattern is to
tear down state in Shutdown(). I'd prefer to avoid changing this code in this
CL.

On 2014/05/14 23:30:28, Peter Kasting wrote:
> Why are the four lines above necessary?

https://codereview.chromium.org/285193002/diff/20001/chrome/browser/google/go...
File chrome/browser/google/google_url_tracker_unittest.cc (right):

https://codereview.chromium.org/285193002/diff/20001/chrome/browser/google/go...
chrome/browser/google/google_url_tracker_unittest.cc:98: //
TestGoogleURLTrackerClient -------------------------------------
On 2014/05/14 23:30:28, Peter Kasting wrote:
> Tiny nit: Can you make all the lines of dashes in this file go out to 79 chars
> like the first two lines (above) do?

Done.

https://codereview.chromium.org/285193002/diff/20001/chrome/browser/google/go...
chrome/browser/google/google_url_tracker_unittest.cc:101: : public
GoogleURLTrackerClient {
On 2014/05/14 23:30:28, Peter Kasting wrote:
> Nit: Linebreak not necessary

Done.

https://codereview.chromium.org/285193002/diff/20001/chrome/browser/google/go...
chrome/browser/google/google_url_tracker_unittest.cc:113: };
On 2014/05/14 23:30:28, Peter Kasting wrote:
> Nit: DISALLOW_COPY_AND_ASSIGN

Done.

https://codereview.chromium.org/285193002/diff/20001/chrome/browser/google/go...
chrome/browser/google/google_url_tracker_unittest.cc:121:
~TestGoogleURLTrackerClient() {
On 2014/05/14 23:30:28, Peter Kasting wrote:
> Nit: Linebreak not necessary

Done.

https://codereview.chromium.org/285193002/diff/20001/chrome/browser/google/go...
chrome/browser/google/google_url_tracker_unittest.cc:126: tracker_ = tracker;
On 2014/05/14 23:30:28, Peter Kasting wrote:
> Since both GoogleURLTrackerClient implementations seem to want to do this,
maybe
> the base class should have a GoogleURLTracker* member, and define a
non-virtual
> cheap public setter ("void set_google_url_tracker(GoogleURLTracker*
> google_url_tracker);") as well as a protected getter ("GoogleURLTracker*
> google_url_tracker();") for the implementations to use.
> 
> I realize this will make the base class non-pure, but I don't think that's a
> problem.  If being able to refer to the owning tracker is a core concept that
> GoogleURLTrackerClients need to do, it makes sense to go ahead and put that
> concrete implementation in the base class.

Done.

https://codereview.chromium.org/285193002/diff/20001/chrome/browser/google/go...
chrome/browser/google/google_url_tracker_unittest.cc:343:
network_change_notifier_.reset();
Removed.

On 2014/05/14 23:30:28, Peter Kasting wrote:
> Why are any of these four lines necessary?

https://codereview.chromium.org/285193002/diff/20001/components/google/core/b...
File components/google/core/browser/google_url_tracker_client.h (right):

https://codereview.chromium.org/285193002/diff/20001/components/google/core/b...
components/google/core/browser/google_url_tracker_client.h:10: // Interface via
which GoogleURLTracker communicates with its embedder.
On 2014/05/14 23:30:28, Peter Kasting wrote:
> Nit: via -> by

Done.

[Peter Kasting, 2014-05-15 21:19:21]

https://codereview.chromium.org/285193002/diff/20001/chrome/browser/google/go...
File chrome/browser/google/google_url_tracker.cc (right):

https://codereview.chromium.org/285193002/diff/20001/chrome/browser/google/go...
chrome/browser/google/google_url_tracker.cc:211:
weak_ptr_factory_.InvalidateWeakPtrs();
On 2014/05/15 07:58:03, blundell wrote:
> I'm not familiar with this code. For KeyedServices, the general pattern is to
> tear down state in Shutdown(). I'd prefer to avoid changing this code in this
> CL.

Ah, I overlooked that this is Shutdown() instead of the destructor.  I still
think we could remove some of these, but I'm not as worried in that case.

https://codereview.chromium.org/285193002/diff/70014/components/google/core/b...
File components/google/core/browser/google_url_tracker_client.cc (right):

https://codereview.chromium.org/285193002/diff/70014/components/google/core/b...
components/google/core/browser/google_url_tracker_client.cc:7: #include
<stddef.h>
I'm skeptical we actually need this for NULL, but if it won't compile otherwise,
use <cstddef> instead.

https://codereview.chromium.org/285193002/diff/70014/components/google/core/b...
File components/google/core/browser/google_url_tracker_client.h (right):

https://codereview.chromium.org/285193002/diff/70014/components/google/core/b...
components/google/core/browser/google_url_tracker_client.h:14: virtual
~GoogleURLTrackerClient() {}
Nit: Since we now have a .cc file and the class is non-pure, let's also put the
destructor definition in that file.

https://codereview.chromium.org/285193002/diff/70014/components/google/core/b...
components/google/core/browser/google_url_tracker_client.h:17: void
set_google_url_tracker(GoogleURLTracker* tracker) { tracker_ = tracker; }
Nit: Google style guide says accessors should match the member name, so I would
either make all function, arg, and member names "tracker" or make them all
"google_url_tracker" (I don't care which).

https://codereview.chromium.org/285193002/diff/70014/components/google/core/b...
components/google/core/browser/google_url_tracker_client.h:32: };
Nit: DISALLOW_COPY_AND_ASSIGN

[blundell, 2014-05-16 08:29:26]

Thanks!

https://codereview.chromium.org/285193002/diff/70014/components/google/core/b...
File components/google/core/browser/google_url_tracker_client.cc (right):

https://codereview.chromium.org/285193002/diff/70014/components/google/core/b...
components/google/core/browser/google_url_tracker_client.cc:7: #include
<stddef.h>
No longer needed after adding the required base/macros.h include in the header.

On 2014/05/15 21:19:21, Peter Kasting wrote:
> I'm skeptical we actually need this for NULL, but if it won't compile
otherwise,
> use <cstddef> instead.

https://codereview.chromium.org/285193002/diff/70014/components/google/core/b...
File components/google/core/browser/google_url_tracker_client.h (right):

https://codereview.chromium.org/285193002/diff/70014/components/google/core/b...
components/google/core/browser/google_url_tracker_client.h:14: virtual
~GoogleURLTrackerClient() {}
On 2014/05/15 21:19:21, Peter Kasting wrote:
> Nit: Since we now have a .cc file and the class is non-pure, let's also put
the
> destructor definition in that file.

Done.

https://codereview.chromium.org/285193002/diff/70014/components/google/core/b...
components/google/core/browser/google_url_tracker_client.h:17: void
set_google_url_tracker(GoogleURLTracker* tracker) { tracker_ = tracker; }
On 2014/05/15 21:19:21, Peter Kasting wrote:
> Nit: Google style guide says accessors should match the member name, so I
would
> either make all function, arg, and member names "tracker" or make them all
> "google_url_tracker" (I don't care which).

Done.

https://codereview.chromium.org/285193002/diff/70014/components/google/core/b...
components/google/core/browser/google_url_tracker_client.h:32: };
On 2014/05/15 21:19:21, Peter Kasting wrote:
> Nit: DISALLOW_COPY_AND_ASSIGN

Done.

[Peter Kasting, 2014-05-16 23:21:08]

LGTM

https://codereview.chromium.org/285193002/diff/70014/chrome/browser/google/go...
File chrome/browser/google/google_url_tracker_unittest.cc (right):

https://codereview.chromium.org/285193002/diff/70014/chrome/browser/google/go...
chrome/browser/google/google_url_tracker_unittest.cc:97: 
Nit: Don't remove this blank line.

https://codereview.chromium.org/285193002/diff/90001/chrome/browser/google/go...
File chrome/browser/google/google_url_tracker.cc (right):

https://codereview.chromium.org/285193002/diff/90001/chrome/browser/google/go...
chrome/browser/google/google_url_tracker.cc:47: prefs::kLastKnownGoogleURL)),
Nit: Wrap like:

      google_url_((mode == UNIT_TEST_MODE) ?
          kDefaultGoogleHomepage :
          profile->GetPrefs()->GetString(prefs::kLastKnownGoogleURL)),

[blundell, 2014-05-17 19:06:06]

https://codereview.chromium.org/285193002/diff/70014/chrome/browser/google/go...
File chrome/browser/google/google_url_tracker_unittest.cc (right):

https://codereview.chromium.org/285193002/diff/70014/chrome/browser/google/go...
chrome/browser/google/google_url_tracker_unittest.cc:97: 
On 2014/05/16 23:21:07, Peter Kasting wrote:
> Nit: Don't remove this blank line.

Done.

https://codereview.chromium.org/285193002/diff/90001/chrome/browser/google/go...
File chrome/browser/google/google_url_tracker.cc (right):

https://codereview.chromium.org/285193002/diff/90001/chrome/browser/google/go...
chrome/browser/google/google_url_tracker.cc:47: prefs::kLastKnownGoogleURL)),
On 2014/05/16 23:21:08, Peter Kasting wrote:
> Nit: Wrap like:
> 
>       google_url_((mode == UNIT_TEST_MODE) ?
>           kDefaultGoogleHomepage :
>           profile->GetPrefs()->GetString(prefs::kLastKnownGoogleURL)),

Done.

[blundell, 2014-05-18 20:57:04]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2014-05-18 20:57:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/blundell@chromium.org/285193002/130001

[commit-bot: I haz the power, 2014-05-18 21:26:02]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)

[commit-bot: I haz the power, 2014-05-18 21:28:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-18 21:28:36]

Try jobs failed on following builders:
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)

[blundell, 2014-05-19 06:19:43]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2014-05-19 06:20:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/blundell@chromium.org/285193002/130001

[commit-bot: I haz the power, 2014-05-19 06:48:42]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)

[commit-bot: I haz the power, 2014-05-19 06:51:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-19 06:51:45]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[blundell, 2014-05-19 09:19:32]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2014-05-19 09:19:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/blundell@chromium.org/285193002/130001

[commit-bot: I haz the power, 2014-05-19 09:46:37]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)

[commit-bot: I haz the power, 2014-05-19 09:50:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-19 09:50:04]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)

[blundell, 2014-05-19 15:17:56]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2014-05-19 15:18:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/blundell@chromium.org/285193002/130001

[commit-bot: I haz the power, 2014-05-19 15:46:06]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)

[commit-bot: I haz the power, 2014-05-19 15:49:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-19 15:49:09]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[blundell, 2014-05-20 07:31:29]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2014-05-20 07:31:53]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/blundell@chromium.org/285193002/150001

[commit-bot: I haz the power, 2014-05-20 09:24:12]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[commit-bot: I haz the power, 2014-05-20 14:49:48]

Change committed as 271638