Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: components/google/core/browser/google_url_tracker_client.h

Issue 285193002: Create GoogleURLTrackerClient interface and //chrome implementation (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Response to review Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef COMPONENTS_GOOGLE_GOOGLE_URL_TRACKER_CLIENT_H_
6 #define COMPONENTS_GOOGLE_GOOGLE_URL_TRACKER_CLIENT_H_
7
8 class GoogleURLTracker;
9
10 // Interface by which GoogleURLTracker communicates with its embedder.
11 class GoogleURLTrackerClient {
12 public:
13 GoogleURLTrackerClient();
14 virtual ~GoogleURLTrackerClient() {}
Peter Kasting 2014/05/15 21:19:21 Nit: Since we now have a .cc file and the class is
blundell 2014/05/16 08:29:26 Done.
15
16 // Sets the GoogleURLTracker that is associated with this client.
17 void set_google_url_tracker(GoogleURLTracker* tracker) { tracker_ = tracker; }
Peter Kasting 2014/05/15 21:19:21 Nit: Google style guide says accessors should matc
blundell 2014/05/16 08:29:26 Done.
18
19 // Enables or disables listening for navigation starts. OnNavigationPending
20 // will be called for each navigation start if listening is enabled.
21 virtual void SetListeningForNavigationStart(bool listen) = 0;
22
23 // Returns whether or not the client is currently listening for navigation
24 // starts.
25 virtual bool IsListeningForNavigationStart() = 0;
26
27 protected:
28 GoogleURLTracker* google_url_tracker() { return tracker_; }
29
30 private:
31 GoogleURLTracker* tracker_;
32 };
Peter Kasting 2014/05/15 21:19:21 Nit: DISALLOW_COPY_AND_ASSIGN
blundell 2014/05/16 08:29:26 Done.
33
34 #endif // COMPONENTS_GOOGLE_GOOGLE_URL_TRACKER_CLIENT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698