components/google/core/browser/google_url_tracker_client.cc - Issue 285193002: Create GoogleURLTrackerClient interface and //chrome implementation

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/google/core/browser/google_url_tracker_client.cc

Issue 285193002: Create GoogleURLTrackerClient interface and //chrome implementation (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Response to review Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "components/google/core/browser/google_url_tracker_client.h"

	6

	7 #include <stddef.h>
	Peter Kasting 2014/05/15 21:19:21 I'm skeptical we actually need this for NULL, but I'm skeptical we actually need this for NULL, but if it won't compile otherwise, use <cstddef> instead. blundell 2014/05/16 08:29:26 No longer needed after adding the required base/ma No longer needed after adding the required base/macros.h include in the header. On 2014/05/15 21:19:21, Peter Kasting wrote: Show quoted text > I'm skeptical we actually need this for NULL, but if it won't compile otherwise, > use <cstddef> instead.
	8

	9 GoogleURLTrackerClient::GoogleURLTrackerClient() : tracker_(NULL) {}

OLD	NEW