Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Unified Diff: chrome/browser/google/google_url_tracker.h

Issue 285193002: Create GoogleURLTrackerClient interface and //chrome implementation (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/google/google_url_tracker.h
diff --git a/chrome/browser/google/google_url_tracker.h b/chrome/browser/google/google_url_tracker.h
index 0b1ca97133e3050b6b099d4744614d2ae49879d3..5e8ba1aea1d238f3f5b3ee030f81f3225ad850bf 100644
--- a/chrome/browser/google/google_url_tracker.h
+++ b/chrome/browser/google/google_url_tracker.h
@@ -21,6 +21,7 @@
#include "net/url_request/url_fetcher_delegate.h"
#include "url/gurl.h"
+class GoogleURLTrackerClient;
class GoogleURLTrackerNavigationHelper;
class PrefService;
class Profile;
@@ -70,6 +71,7 @@ class GoogleURLTracker : public net::URLFetcherDelegate,
// than the GoogleURLTracker itself should actually use
// GoogleURLTrackerFactory::GetForProfile().
GoogleURLTracker(Profile* profile,
+ scoped_ptr<GoogleURLTrackerClient> client,
scoped_ptr<GoogleURLTrackerNavigationHelper> nav_helper,
Mode mode);
@@ -109,12 +111,12 @@ class GoogleURLTracker : public net::URLFetcherDelegate,
// No one but GoogleURLTrackerMapEntry should call this.
void DeleteMapEntryForService(const InfoBarService* infobar_service);
- // Called by the navigation observer after SearchCommitted() registers
- // listeners, to indicate that we've received the "load now pending"
- // notification. |navigation_controller| is the NavigationController for this
- // load; |infobar_service| is the InfoBarService of the associated tab; and
- // |pending_id| is the unique ID of the newly pending NavigationEntry.
- // If there is already a visible GoogleURLTracker infobar for this tab, this
+ // Called by the client after SearchCommitted() registers listeners, to
+ // indicate that we've received the "load now pending" notification.
+ // |navigation_controller| is the NavigationController for this load;
+ // |infobar_service| is the InfoBarService of the associated tab; and
+ // |pending_id| is the unique ID of the newly pending NavigationEntry. If
+ // there is already a visible GoogleURLTracker infobar for this tab, this
// function resets its associated pending entry ID to the new ID. Otherwise
// this function creates a map entry for the associated tab.
virtual void OnNavigationPending(
@@ -188,6 +190,8 @@ class GoogleURLTracker : public net::URLFetcherDelegate,
Profile* profile_;
+ scoped_ptr<GoogleURLTrackerClient> client_;
+
scoped_ptr<GoogleURLTrackerNavigationHelper> nav_helper_;
// Creates an infobar and adds it to the provided InfoBarService. Returns the
« no previous file with comments | « chrome/browser/google/chrome_google_url_tracker_client.cc ('k') | chrome/browser/google/google_url_tracker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698