Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2851823002: Reland of DevTools: fix aggregated donut chart cache population (Closed)

Created:
3 years, 7 months ago by alph
Modified:
3 years, 7 months ago
Reviewers:
sashab, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of DevTools: fix aggregated donut chart cache population (patchset #1 id:1 of https://codereview.chromium.org/2839083002/ ) Reason for revert: The patch has noting to do with the failing test. In fact if you look at the flakiness dashboard the test is very flaky there: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=virtual%2Fthreaded%2Finspector%2Ftracing%2Ftimeline-js%2Ftimeline-runtime-stats.html Original issue's description: > Revert of DevTools: fix aggregated donut chart cache population (patchset #1 id:1 of https://codereview.chromium.org/2840463003/ ) > > Reason for revert: > Suspected cause of failure of virtual/threaded/inspector/tracing/timeline-js/timeline-runtime-stats.html in https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20(dbg)/builds/9644 > > Original issue's description: > > DevTools: fix aggregated donut chart cache population > > > > The check for stats cache availablity was made on the first task in the main thread > > tasks list. If the first task happens to be filtered out, it never gets cache built for > > it. Later the cache presence check would look for a cache on the first task, never find > > it and forces recaching. > > > > BUG=714934 > > > > Review-Url: https://codereview.chromium.org/2840463003 > > Cr-Commit-Position: refs/heads/master@{#467114} > > Committed: https://chromium.googlesource.com/chromium/src/+/755b1656f38d135013f24ddd8b6ec046874beed2 > > TBR=pfeldman@chromium.org,alph@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=714934 > > Review-Url: https://codereview.chromium.org/2839083002 > Cr-Commit-Position: refs/heads/master@{#467223} > Committed: https://chromium.googlesource.com/chromium/src/+/65df576fce3007b62084239cc8e37a45aea0368f TBR=pfeldman@chromium.org,sashab@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=714934 Review-Url: https://codereview.chromium.org/2851823002 Cr-Commit-Position: refs/heads/master@{#468119} Committed: https://chromium.googlesource.com/chromium/src/+/2e2708b5c1cb31e5d4dde1f105af1c473795d3b9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
alph
Created Reland of DevTools: fix aggregated donut chart cache population
3 years, 7 months ago (2017-04-28 18:59:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2851823002/1
3 years, 7 months ago (2017-04-28 19:00:46 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 20:47:16 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2e2708b5c1cb31e5d4dde1f105af...

Powered by Google App Engine
This is Rietveld 408576698