Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2839083002: Revert of DevTools: fix aggregated donut chart cache population (Closed)

Created:
3 years, 8 months ago by sashab
Modified:
3 years, 8 months ago
Reviewers:
alph, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: fix aggregated donut chart cache population (patchset #1 id:1 of https://codereview.chromium.org/2840463003/ ) Reason for revert: Suspected cause of failure of virtual/threaded/inspector/tracing/timeline-js/timeline-runtime-stats.html in https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20(dbg)/builds/9644 Original issue's description: > DevTools: fix aggregated donut chart cache population > > The check for stats cache availablity was made on the first task in the main thread > tasks list. If the first task happens to be filtered out, it never gets cache built for > it. Later the cache presence check would look for a cache on the first task, never find > it and forces recaching. > > BUG=714934 > > Review-Url: https://codereview.chromium.org/2840463003 > Cr-Commit-Position: refs/heads/master@{#467114} > Committed: https://chromium.googlesource.com/chromium/src/+/755b1656f38d135013f24ddd8b6ec046874beed2 TBR=pfeldman@chromium.org,alph@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=714934 Review-Url: https://codereview.chromium.org/2839083002 Cr-Commit-Position: refs/heads/master@{#467223} Committed: https://chromium.googlesource.com/chromium/src/+/65df576fce3007b62084239cc8e37a45aea0368f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
sashab
Created Revert of DevTools: fix aggregated donut chart cache population
3 years, 8 months ago (2017-04-26 03:50:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2839083002/1
3 years, 8 months ago (2017-04-26 03:50:41 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/65df576fce3007b62084239cc8e37a45aea0368f
3 years, 8 months ago (2017-04-26 03:51:17 UTC) #6
alph
3 years, 7 months ago (2017-04-28 18:59:28 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2851823002/ by alph@chromium.org.

The reason for reverting is: The patch has noting to do with the failing test.
In fact if you look at the flakiness dashboard the test is very flaky there:

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType....

Powered by Google App Engine
This is Rietveld 408576698