Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2840463003: DevTools: fix aggregated donut chart cache population (Closed)

Created:
3 years, 8 months ago by alph
Modified:
3 years, 8 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: fix aggregated donut chart cache population The check for stats cache availablity was made on the first task in the main thread tasks list. If the first task happens to be filtered out, it never gets cache built for it. Later the cache presence check would look for a cache on the first task, never find it and forces recaching. BUG=714934 Review-Url: https://codereview.chromium.org/2840463003 Cr-Commit-Position: refs/heads/master@{#467114} Committed: https://chromium.googlesource.com/chromium/src/+/755b1656f38d135013f24ddd8b6ec046874beed2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
alph
3 years, 8 months ago (2017-04-25 01:38:18 UTC) #3
pfeldman
lgtm
3 years, 8 months ago (2017-04-25 21:07:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2840463003/1
3 years, 8 months ago (2017-04-25 21:09:41 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/755b1656f38d135013f24ddd8b6ec046874beed2
3 years, 8 months ago (2017-04-25 21:18:28 UTC) #13
sashab
3 years, 8 months ago (2017-04-26 03:50:23 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2839083002/ by sashab@chromium.org.

The reason for reverting is: Suspected cause of failure of
virtual/threaded/inspector/tracing/timeline-js/timeline-runtime-stats.html in
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20(dbg)/b....

Powered by Google App Engine
This is Rietveld 408576698