Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 2851703002: Remove the enable flag from all plugins after the option has been ported. (Closed)

Created:
3 years, 7 months ago by pastarmovj
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Remove the enable flag from all plugins after the option has been ported. https://codereview.chromium.org/2518493002 removed the code to reenable plugins but this doesn't reset the state and end up overwriting the new pdf/flash setting each time the old prefs are read again. After the CL the flag was not added to new Preferences files this code only applies to existing legacy settings. BUG=705979 Review-Url: https://codereview.chromium.org/2841843002 Cr-Commit-Position: refs/heads/master@{#467285} (cherry picked from commit e08ac360faf4df6fc67b419d549ad682f8e56962) Review-Url: https://codereview.chromium.org/2851703002 . Cr-Commit-Position: refs/branch-heads/3071@{#286} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/df3bb192e93b863cde928dd9416976180bfb24ae

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/plugins/plugin_prefs.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
pastarmovj
3 years, 7 months ago (2017-04-28 07:50:41 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
df3bb192e93b863cde928dd9416976180bfb24ae.

Powered by Google App Engine
This is Rietveld 408576698