Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(27)

Issue 2518493002: Remove obsolete plugin state handling code. (Closed)

Created:
2 years, 7 months ago by pastarmovj
Modified:
2 years, 7 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove obsolete plugin state handling code. As a byproduct clean up some old Adobe PDF Plugin handling code which is now obsolete as well. BUG=662002 TEST=unit_tests, browser_tests Committed: https://crrev.com/8b32e59714ad13709b8ced2b709e903fcc5caf8e Cr-Commit-Position: refs/heads/master@{#433549}

Patch Set 1 #

Patch Set 2 : Fix the pdf test. #

Patch Set 3 : Removed unusued function. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1214 lines) Patch
M chrome/browser/chrome_plugin_browsertest.cc View 2 chunks +0 lines, -30 lines 0 comments Download
M chrome/browser/pdf/pdf_extension_test.cc View 1 4 chunks +4 lines, -20 lines 0 comments Download
M chrome/browser/plugins/plugin_prefs.h View 3 chunks +1 line, -70 lines 0 comments Download
M chrome/browser/plugins/plugin_prefs.cc View 14 chunks +0 lines, -291 lines 0 comments Download
M chrome/browser/plugins/plugin_prefs_unittest.cc View 1 chunk +0 lines, -268 lines 0 comments Download
M chrome/browser/printing/print_preview_dialog_controller_browsertest.cc View 2 chunks +6 lines, -8 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/pdf/adobe_reader_info_win.h View 1 chunk +0 lines, -27 lines 0 comments Download
M chrome/browser/ui/pdf/adobe_reader_info_win.cc View 1 3 chunks +1 line, -83 lines 0 comments Download
M chrome/browser/ui/pdf/chrome_pdf_web_contents_helper_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/ui/pdf/pdf_unsupported_feature.h View 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/browser/ui/pdf/pdf_unsupported_feature.cc View 1 chunk +0 lines, -366 lines 0 comments Download
M chrome/browser/ui/webui/plugins/plugins_handler.cc View 1 2 2 chunks +2 lines, -28 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
pastarmovj
Hi Bernhard, This is the cleanup promised in me previous CL. :) Cheers and have ...
2 years, 7 months ago (2016-11-18 14:33:00 UTC) #3
Bernhard Bauer
Look at all that removed code :) LGTM
2 years, 7 months ago (2016-11-18 14:51:04 UTC) #4
pastarmovj
Adding Jochen for the rest of the files. Thanks!
2 years, 7 months ago (2016-11-18 15:10:23 UTC) #6
jochen (gone - plz use gerrit)
lgtm
2 years, 7 months ago (2016-11-21 10:59:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2518493002/40001
2 years, 7 months ago (2016-11-21 11:17:02 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/238590)
2 years, 7 months ago (2016-11-21 11:30:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2518493002/60001
2 years, 7 months ago (2016-11-21 12:56:16 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:60001)
2 years, 7 months ago (2016-11-21 15:31:16 UTC) #16
commit-bot: I haz the power
2 years, 7 months ago (2016-11-21 15:33:51 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8b32e59714ad13709b8ced2b709e903fcc5caf8e
Cr-Commit-Position: refs/heads/master@{#433549}

Powered by Google App Engine
This is Rietveld 408576698