Remove the enable flag from all plugins after the option has been ported.

Remove the enable flag from all plugins after the option has been ported.

https://codereview.chromium.org/2518493002 removed the code to reenable
plugins but this doesn't reset the state and end up overwriting the
new pdf/flash setting each time the old prefs are read again.

After the CL the flag was not added to new Preferences files this code only applies to existing legacy settings.

BUG=705979
Review-Url: https://codereview.chromium.org/2841843002
Cr-Commit-Position: refs/heads/master@{#467285}
Committed: https://chromium.googlesource.com/chromium/src/+/e08ac360faf4df6fc67b419d549ad682f8e56962

[pastarmovj, 2017-04-25 12:54:13]

The CQ bit was checked by pastarmovj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 12:54:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 13:42:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 13:42:17]

Dry run: This issue passed the CQ dry run.

[pastarmovj, 2017-04-25 13:44:17]

pastarmovj@chromium.org changed reviewers:
+ bauerb@chromium.org

[pastarmovj, 2017-04-25 13:44:18]

Hi Bernhard,
please review this small but smooth fix :)
Thanks!
Julian

[pastarmovj, 2017-04-25 13:45:00]

Description was changed from

==========
Remove the enable flag from all plugins after the option has been ported.

https://codereview.chromium.org/2518493002 removed the code to reenable
plugins but this doesn't reset the state and end up overwriting the
new pdf/flash setting each time the old prefs are read again.

BUG=705979
==========

to

==========
Remove the enable flag from all plugins after the option has been ported.

https://codereview.chromium.org/2518493002 removed the code to reenable
plugins but this doesn't reset the state and end up overwriting the
new pdf/flash setting each time the old prefs are read again.

After the CL the flag was not added to new Preferences files this code only
applies to existing legacy settings.

BUG=705979
==========

[Bernhard Bauer, 2017-04-25 14:15:38]

https://codereview.chromium.org/2841843002/diff/1/chrome/browser/plugins/plug...
File chrome/browser/plugins/plugin_prefs.cc (right):

https://codereview.chromium.org/2841843002/diff/1/chrome/browser/plugins/plug...
chrome/browser/plugins/plugin_prefs.cc:139: bool enabled;
I would simplify this to:

  bool enabled = true;
  if (plugin->GetBoolean("enabled", &enabled))
    plugin->Remove("enabled", nullptr);

[pastarmovj, 2017-04-26 07:26:38]

https://codereview.chromium.org/2841843002/diff/1/chrome/browser/plugins/plug...
File chrome/browser/plugins/plugin_prefs.cc (right):

https://codereview.chromium.org/2841843002/diff/1/chrome/browser/plugins/plug...
chrome/browser/plugins/plugin_prefs.cc:139: bool enabled;
On 2017/04/25 14:15:37, Bernhard Bauer wrote:
> I would simplify this to:
> 
>   bool enabled = true;
>   if (plugin->GetBoolean("enabled", &enabled))
>     plugin->Remove("enabled", nullptr);

Done.

[Bernhard Bauer, 2017-04-26 09:22:53]

lgtm

[pastarmovj, 2017-04-26 09:44:27]

The CQ bit was checked by pastarmovj@chromium.org

[commit-bot: I haz the power, 2017-04-26 09:44:35]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 10:27:40]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493199867856340,
"parent_rev": "33930987a0aa0ad3c44c8d13019e05a417d64d6a", "commit_rev":
"e08ac360faf4df6fc67b419d549ad682f8e56962"}

[commit-bot: I haz the power, 2017-04-26 10:27:56]

Description was changed from

==========
Remove the enable flag from all plugins after the option has been ported.

https://codereview.chromium.org/2518493002 removed the code to reenable
plugins but this doesn't reset the state and end up overwriting the
new pdf/flash setting each time the old prefs are read again.

After the CL the flag was not added to new Preferences files this code only
applies to existing legacy settings.

BUG=705979
==========

to

==========
Remove the enable flag from all plugins after the option has been ported.

https://codereview.chromium.org/2518493002 removed the code to reenable
plugins but this doesn't reset the state and end up overwriting the
new pdf/flash setting each time the old prefs are read again.

After the CL the flag was not added to new Preferences files this code only
applies to existing legacy settings.

BUG=705979

Review-Url: https://codereview.chromium.org/2841843002
Cr-Commit-Position: refs/heads/master@{#467285}
Committed:
https://chromium.googlesource.com/chromium/src/+/e08ac360faf4df6fc67b419d549a...
==========

[commit-bot: I haz the power, 2017-04-26 10:27:57]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e08ac360faf4df6fc67b419d549a...