Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2850383002: Reland: Don't store ScriptValue in PopStateEvent (Closed)

Created:
3 years, 7 months ago by bashi
Modified:
3 years, 7 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Don't store ScriptValue in PopStateEvent Fix compilation errors (rebased). Original description: Use TraceWrapperV8Reference instead. This CL doesn't remove custom getter of PopStateEvent.state as more work will be needed to remove custom bindings. BUG=501866 Review-Url: https://codereview.chromium.org/2850383002 Cr-Commit-Position: refs/heads/master@{#468582} Committed: https://chromium.googlesource.com/chromium/src/+/ccffbeec870b3c375c0dbb9f3368b87766a7d6e5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -12 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/custom/V8PopStateEventCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/PopStateEvent.h View 3 chunks +11 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/events/PopStateEvent.cpp View 3 chunks +31 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/events/PopStateEvent.idl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
bashi
PTAL
3 years, 7 months ago (2017-05-02 08:01:48 UTC) #6
haraken
LGTM
3 years, 7 months ago (2017-05-02 08:02:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2850383002/1
3 years, 7 months ago (2017-05-02 08:03:47 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 08:07:39 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ccffbeec870b3c375c0dbb9f3368...

Powered by Google App Engine
This is Rietveld 408576698