Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8PopStateEventCustom.cpp

Issue 2850383002: Reland: Don't store ScriptValue in PopStateEvent (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/events/PopStateEvent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/custom/V8PopStateEventCustom.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8PopStateEventCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8PopStateEventCustom.cpp
index 7862158a79940f235580e7a8414a105b4c766d91..b04641eca42a5f7ec3912b8a88950766bf79eef0 100644
--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8PopStateEventCustom.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8PopStateEventCustom.cpp
@@ -77,7 +77,7 @@ void V8PopStateEvent::stateAttributeGetterCustom(
if (event->SerializedState())
result = event->SerializedState()->Deserialize(isolate);
else
- result = event->state().V8ValueFor(script_state);
+ result = event->state(script_state).V8Value();
if (result.IsEmpty())
result = v8::Null(isolate);
V8SetReturnValue(info, CacheState(script_state, info.Holder(), result));
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/events/PopStateEvent.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698