Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Side by Side Diff: third_party/WebKit/Source/core/events/PopStateEvent.h

Issue 2850383002: Reland: Don't store ScriptValue in PopStateEvent (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2009 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution. 11 * documentation and/or other materials provided with the distribution.
12 * 12 *
13 * THIS SOFTWARE IS PROVIDED BY APPLE, INC. ``AS IS'' AND ANY 13 * THIS SOFTWARE IS PROVIDED BY APPLE, INC. ``AS IS'' AND ANY
14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR 16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR
17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, 17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, 18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR 19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY 20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 * 24 *
25 */ 25 */
26 26
27 #ifndef PopStateEvent_h 27 #ifndef PopStateEvent_h
28 #define PopStateEvent_h 28 #define PopStateEvent_h
29 29
30 #include "bindings/core/v8/TraceWrapperV8Reference.h"
30 #include "core/events/Event.h" 31 #include "core/events/Event.h"
31 #include "core/events/PopStateEventInit.h" 32 #include "core/events/PopStateEventInit.h"
33 #include "platform/bindings/DOMWrapperWorld.h"
32 #include "platform/heap/Handle.h" 34 #include "platform/heap/Handle.h"
33 35
34 namespace blink { 36 namespace blink {
35 37
36 class History; 38 class History;
37 class SerializedScriptValue; 39 class SerializedScriptValue;
38 40
39 class PopStateEvent final : public Event { 41 class PopStateEvent final : public Event {
40 DEFINE_WRAPPERTYPEINFO(); 42 DEFINE_WRAPPERTYPEINFO();
41 43
42 public: 44 public:
43 ~PopStateEvent() override; 45 ~PopStateEvent() override;
44 static PopStateEvent* Create(); 46 static PopStateEvent* Create();
45 static PopStateEvent* Create(PassRefPtr<SerializedScriptValue>, History*); 47 static PopStateEvent* Create(PassRefPtr<SerializedScriptValue>, History*);
46 static PopStateEvent* Create(const AtomicString&, const PopStateEventInit&); 48 static PopStateEvent* Create(ScriptState*,
49 const AtomicString&,
50 const PopStateEventInit&);
47 51
48 ScriptValue state() const { return state_; } 52 ScriptValue state(ScriptState*) const;
49 SerializedScriptValue* SerializedState() const { 53 SerializedScriptValue* SerializedState() const {
50 return serialized_state_.Get(); 54 return serialized_state_.Get();
51 } 55 }
52 void SetSerializedState(PassRefPtr<SerializedScriptValue> state) { 56 void SetSerializedState(PassRefPtr<SerializedScriptValue> state) {
53 DCHECK(!serialized_state_); 57 DCHECK(!serialized_state_);
54 serialized_state_ = std::move(state); 58 serialized_state_ = std::move(state);
55 } 59 }
56 History* GetHistory() const { return history_.Get(); } 60 History* GetHistory() const { return history_.Get(); }
57 61
58 const AtomicString& InterfaceName() const override; 62 const AtomicString& InterfaceName() const override;
59 63
60 DECLARE_VIRTUAL_TRACE(); 64 DECLARE_VIRTUAL_TRACE();
61 65
66 DECLARE_VIRTUAL_TRACE_WRAPPERS();
67
62 private: 68 private:
63 PopStateEvent(); 69 PopStateEvent();
64 PopStateEvent(const AtomicString&, const PopStateEventInit&); 70 PopStateEvent(ScriptState*, const AtomicString&, const PopStateEventInit&);
65 PopStateEvent(PassRefPtr<SerializedScriptValue>, History*); 71 PopStateEvent(PassRefPtr<SerializedScriptValue>, History*);
66 72
67 RefPtr<SerializedScriptValue> serialized_state_; 73 RefPtr<SerializedScriptValue> serialized_state_;
68 ScriptValue state_; 74 RefPtr<DOMWrapperWorld> world_;
75 TraceWrapperV8Reference<v8::Value> state_;
69 Member<History> history_; 76 Member<History> history_;
70 }; 77 };
71 78
72 } // namespace blink 79 } // namespace blink
73 80
74 #endif // PopStateEvent_h 81 #endif // PopStateEvent_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698