PaymentHandler: Implement PaymentInstruments.keys().

content/browser/payments/payment_manager_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <utility>
 
 #include "base/macros.h"
 #include "base/run_loop.h"
 #include "components/payments/mojom/payment_app.mojom.h"
 #include "content/browser/payments/payment_app_content_unittest_base.h"
@@ skipping 32 matching lines @@
 void DeletePaymentInstrumentCallback(PaymentHandlerStatus* out_status,
                                      PaymentHandlerStatus status) {
   *out_status = status;
 }
 
 void SetPaymentInstrumentCallback(PaymentHandlerStatus* out_status,
                                   PaymentHandlerStatus status) {
   *out_status = status;
 }
 
+void KeysOfPaymentInstrumentsCallback(std::vector<std::string>* out_keys,
+                                      PaymentHandlerStatus* out_status,
+                                      const std::vector<std::string>& keys,
+                                      PaymentHandlerStatus status) {
+  *out_keys = keys;
+  *out_status = status;
+}
+
 void HasPaymentInstrumentCallback(PaymentHandlerStatus* out_status,
                                   PaymentHandlerStatus status) {
   *out_status = status;
 }
 
 void GetPaymentInstrumentCallback(PaymentInstrumentPtr* out_instrument,
                                   PaymentHandlerStatus* out_status,
                                   PaymentInstrumentPtr instrument,
                                   PaymentHandlerStatus status) {
   *out_instrument = std::move(instrument);
@@ skipping 22 matching lines @@
 
   void SetPaymentInstrument(const std::string& instrument_key,
                             PaymentInstrumentPtr instrument,
                             PaymentHandlerStatus* out_status) {
     manager_->SetPaymentInstrument(
         instrument_key, std::move(instrument),
         base::Bind(&SetPaymentInstrumentCallback, out_status));
     base::RunLoop().RunUntilIdle();
   }
 
+  void KeysOfPaymentInstruments(std::vector<std::string>* out_keys,
+                                PaymentHandlerStatus* out_status) {
+    manager_->KeysOfPaymentInstruments(
+        base::Bind(&KeysOfPaymentInstrumentsCallback, out_keys, out_status));
+    base::RunLoop().RunUntilIdle();
+  }
+
   void HasPaymentInstrument(const std::string& instrument_key,
                             PaymentHandlerStatus* out_status) {
     manager_->HasPaymentInstrument(
         instrument_key, base::Bind(&HasPaymentInstrumentCallback, out_status));
     base::RunLoop().RunUntilIdle();
   }
 
   void GetPaymentInstrument(const std::string& instrument_key,
                             PaymentInstrumentPtr* out_instrument,
                             PaymentHandlerStatus* out_status) {
@@ skipping 135 matching lines @@
   ASSERT_EQ(PaymentHandlerStatus::SUCCESS, write_status);
 
   PaymentHandlerStatus has_status = PaymentHandlerStatus::NOT_FOUND;
   HasPaymentInstrument("test_key", &has_status);
   ASSERT_EQ(PaymentHandlerStatus::SUCCESS, has_status);
 
   HasPaymentInstrument("unstored_test_key", &has_status);
   ASSERT_EQ(PaymentHandlerStatus::NOT_FOUND, has_status);
 }
 
+TEST_F(PaymentManagerTest, KeysOfPaymentInstruments) {

[Tom Sepez, 2017/05/01 17:49:33]

Maybe also test sending back an empty array to be sure that case is handled.

[zino, 2017/05/02 15:03:58]

Done.

+  {
+    PaymentHandlerStatus write_status = PaymentHandlerStatus::NOT_FOUND;
+    SetPaymentInstrument("test_key1", PaymentInstrument::New(), &write_status);
+    ASSERT_EQ(PaymentHandlerStatus::SUCCESS, write_status);
+  }
+  {
+    PaymentHandlerStatus write_status = PaymentHandlerStatus::NOT_FOUND;
+    SetPaymentInstrument("test_key3", PaymentInstrument::New(), &write_status);
+    ASSERT_EQ(PaymentHandlerStatus::SUCCESS, write_status);
+  }
+  {
+    PaymentHandlerStatus write_status = PaymentHandlerStatus::NOT_FOUND;
+    SetPaymentInstrument("test_key2", PaymentInstrument::New(), &write_status);
+    ASSERT_EQ(PaymentHandlerStatus::SUCCESS, write_status);
+  }
+
+  PaymentHandlerStatus keys_status = PaymentHandlerStatus::NOT_FOUND;
+  std::vector<std::string> keys;
+  KeysOfPaymentInstruments(&keys, &keys_status);
+  ASSERT_EQ(3U, keys.size());
+  ASSERT_EQ("test_key1", keys[0]);
+  ASSERT_EQ("test_key3", keys[1]);
+  ASSERT_EQ("test_key2", keys[2]);
+}
+
 }  // namespace content