Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2850143002: Reuse RuntimeTypesNeedBuilderImpl and _RuntimeTypesNeed for kernel based elements (Closed)

Created:
3 years, 7 months ago by Johnni Winther
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reuse RuntimeTypesNeedBuilderImpl and _RuntimeTypesNeed for kernel based elements R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/e4131c2d37007843ec9fdc549169c0f71ba53e1a

Patch Set 1 #

Patch Set 2 : Fix comment #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -181 lines) Patch
M pkg/compiler/lib/src/common_elements.dart View 2 chunks +4 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/resolution_types.dart View 1 chunk +10 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/elements/types.dart View 1 chunk +10 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/resolution_listener.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/runtime_types.dart View 1 10 chunks +149 lines, -73 lines 2 comments Download
M pkg/compiler/lib/src/kernel/element_map.dart View 2 chunks +15 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_strategy.dart View 2 chunks +2 lines, -22 lines 0 comments Download
M pkg/compiler/lib/src/kernel/types.dart View 3 chunks +16 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution_strategy.dart View 2 chunks +7 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/universe/resolution_world_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/kernel/closed_world2_test.dart View 1 chunk +0 lines, -66 lines 1 comment Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
https://codereview.chromium.org/2850143002/diff/20001/tests/compiler/dart2js/kernel/closed_world2_test.dart File tests/compiler/dart2js/kernel/closed_world2_test.dart (left): https://codereview.chromium.org/2850143002/diff/20001/tests/compiler/dart2js/kernel/closed_world2_test.dart#oldcode183 tests/compiler/dart2js/kernel/closed_world2_test.dart:183: List createKernelResolutionEnqueuerListener( No longer used.
3 years, 7 months ago (2017-05-01 11:56:20 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2850143002/diff/20001/pkg/compiler/lib/src/js_backend/runtime_types.dart File pkg/compiler/lib/src/js_backend/runtime_types.dart (right): https://codereview.chromium.org/2850143002/diff/20001/pkg/compiler/lib/src/js_backend/runtime_types.dart#newcode171 pkg/compiler/lib/src/js_backend/runtime_types.dart:171: // TODO(johnniwinther): This seems wrong; the type arguments ...
3 years, 7 months ago (2017-05-02 19:56:50 UTC) #3
Johnni Winther
https://codereview.chromium.org/2850143002/diff/20001/pkg/compiler/lib/src/js_backend/runtime_types.dart File pkg/compiler/lib/src/js_backend/runtime_types.dart (right): https://codereview.chromium.org/2850143002/diff/20001/pkg/compiler/lib/src/js_backend/runtime_types.dart#newcode171 pkg/compiler/lib/src/js_backend/runtime_types.dart:171: // TODO(johnniwinther): This seems wrong; the type arguments of ...
3 years, 7 months ago (2017-05-03 07:36:33 UTC) #4
Johnni Winther
3 years, 7 months ago (2017-05-03 07:54:30 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
e4131c2d37007843ec9fdc549169c0f71ba53e1a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698