Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Unified Diff: tests/compiler/dart2js/kernel/closed_world2_test.dart

Issue 2850143002: Reuse RuntimeTypesNeedBuilderImpl and _RuntimeTypesNeed for kernel based elements (Closed)
Patch Set: Fix comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/compiler/dart2js/kernel/closed_world2_test.dart
diff --git a/tests/compiler/dart2js/kernel/closed_world2_test.dart b/tests/compiler/dart2js/kernel/closed_world2_test.dart
index e8af45d1501f635352c847cdbdf939f29bbd02ec..92d06b130d54a31f55390270234364a2aaf272b2 100644
--- a/tests/compiler/dart2js/kernel/closed_world2_test.dart
+++ b/tests/compiler/dart2js/kernel/closed_world2_test.dart
@@ -180,72 +180,6 @@ Future mainInternal(List<String> args,
verbose: arguments.verbose);
}
-List createKernelResolutionEnqueuerListener(
Johnni Winther 2017/05/01 11:56:20 No longer used.
- CompilerOptions options,
- DiagnosticReporter reporter,
- DeferredLoadTask deferredLoadTask,
- KernelToElementMap elementMap,
- NativeBasicData nativeBasicData) {
- ElementEnvironment elementEnvironment = elementMap.elementEnvironment;
- CommonElements commonElements = elementMap.commonElements;
- BackendImpacts impacts = new BackendImpacts(options, commonElements);
-
- // TODO(johnniwinther): Create Kernel based implementations for these:
- RuntimeTypesNeedBuilder rtiNeedBuilder = new RuntimeTypesNeedBuilderImpl();
- MirrorsDataBuilder mirrorsDataBuilder = new MirrorsDataBuilderImpl();
- CustomElementsResolutionAnalysis customElementsResolutionAnalysis =
- new CustomElementsResolutionAnalysisImpl();
- MirrorsResolutionAnalysis mirrorsResolutionAnalysis =
- new MirrorsResolutionAnalysisImpl();
-
- LookupMapResolutionAnalysis lookupMapResolutionAnalysis =
- new LookupMapResolutionAnalysis(reporter, elementEnvironment);
- InterceptorDataBuilder interceptorDataBuilder =
- new InterceptorDataBuilderImpl(
- nativeBasicData, elementEnvironment, commonElements);
- BackendUsageBuilder backendUsageBuilder =
- new BackendUsageBuilderImpl(commonElements);
- NoSuchMethodRegistry noSuchMethodRegistry = new NoSuchMethodRegistry(
- commonElements, new KernelNoSuchMethodResolver(elementMap));
- NativeClassFinder nativeClassFinder = new BaseNativeClassFinder(
- elementEnvironment, commonElements, nativeBasicData);
- NativeResolutionEnqueuer nativeResolutionEnqueuer =
- new NativeResolutionEnqueuer(options, elementEnvironment, commonElements,
- backendUsageBuilder, nativeClassFinder);
-
- ResolutionEnqueuerListener listener = new ResolutionEnqueuerListener(
- options,
- elementEnvironment,
- commonElements,
- impacts,
- nativeBasicData,
- interceptorDataBuilder,
- backendUsageBuilder,
- rtiNeedBuilder,
- mirrorsDataBuilder,
- noSuchMethodRegistry,
- customElementsResolutionAnalysis,
- lookupMapResolutionAnalysis,
- mirrorsResolutionAnalysis,
- new TypeVariableResolutionAnalysis(
- elementEnvironment, impacts, backendUsageBuilder),
- nativeResolutionEnqueuer,
- deferredLoadTask);
-
- ImpactTransformer transformer = new JavaScriptImpactTransformer(
- options,
- elementEnvironment,
- commonElements,
- impacts,
- nativeBasicData,
- nativeResolutionEnqueuer,
- backendUsageBuilder,
- mirrorsDataBuilder,
- customElementsResolutionAnalysis,
- rtiNeedBuilder);
- return [listener, backendUsageBuilder, transformer];
-}
-
void checkNativeBasicData(NativeBasicDataImpl data1, NativeBasicDataImpl data2,
KernelEquivalence equivalence) {
checkMapEquivalence(

Powered by Google App Engine
This is Rietveld 408576698