Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pkg/compiler/lib/src/js_backend/resolution_listener.dart

Issue 2850143002: Reuse RuntimeTypesNeedBuilderImpl and _RuntimeTypesNeed for kernel based elements (Closed)
Patch Set: Fix comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/js_backend/backend.dart ('k') | pkg/compiler/lib/src/js_backend/runtime_types.dart » ('j') | pkg/compiler/lib/src/js_backend/runtime_types.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_backend/resolution_listener.dart
diff --git a/pkg/compiler/lib/src/js_backend/resolution_listener.dart b/pkg/compiler/lib/src/js_backend/resolution_listener.dart
index b93283823b73dd771aefd0894784b5f7908bb1f4..af08ceb09f0406da16425f04c5134988776a90f6 100644
--- a/pkg/compiler/lib/src/js_backend/resolution_listener.dart
+++ b/pkg/compiler/lib/src/js_backend/resolution_listener.dart
@@ -309,7 +309,7 @@ class ResolutionEnqueuerListener extends EnqueuerListener {
ClassEntity cls = method.enclosingClass;
if (method.name == Identifiers.call &&
- _elementEnvironment.getThisType(cls).typeArguments.isNotEmpty) {
+ _elementEnvironment.isGenericClass(cls)) {
worldImpact.addImpact(_registerComputeSignature());
}
}
@@ -368,7 +368,7 @@ class ResolutionEnqueuerListener extends EnqueuerListener {
WorldImpact _processClass(ClassEntity cls) {
WorldImpactBuilderImpl impactBuilder = new WorldImpactBuilderImpl();
- if (_elementEnvironment.getThisType(cls).typeArguments.isNotEmpty) {
+ if (_elementEnvironment.isGenericClass(cls)) {
_typeVariableResolutionAnalysis.registerClassWithTypeVariables(cls);
}
// TODO(johnniwinther): Extract an `implementationClassesOf(...)` function
« no previous file with comments | « pkg/compiler/lib/src/js_backend/backend.dart ('k') | pkg/compiler/lib/src/js_backend/runtime_types.dart » ('j') | pkg/compiler/lib/src/js_backend/runtime_types.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698