Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Unified Diff: pkg/compiler/lib/src/ssa/builder.dart

Issue 2850143002: Reuse RuntimeTypesNeedBuilderImpl and _RuntimeTypesNeed for kernel based elements (Closed)
Patch Set: Fix comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/ssa/builder.dart
diff --git a/pkg/compiler/lib/src/ssa/builder.dart b/pkg/compiler/lib/src/ssa/builder.dart
index 235113269e42668b1b34b43e08acb371511d10fa..2b11417b29561e4b6dcf587e5775c26efa26b06a 100644
--- a/pkg/compiler/lib/src/ssa/builder.dart
+++ b/pkg/compiler/lib/src/ssa/builder.dart
@@ -1239,7 +1239,7 @@ class SsaBuilder extends ast.Visitor
if (!isNativeUpgradeFactory) {
// Create the runtime type information, if needed.
bool hasRtiInput = false;
- if (rtiNeed.classNeedsRtiField(classElement)) {
+ if (rtiNeed.classNeedsRtiField(classElement.declaration)) {
// Read the values of the type arguments and create a
// HTypeInfoExpression to set on the newly create object.
hasRtiInput = true;
@@ -1378,7 +1378,7 @@ class SsaBuilder extends ast.Visitor
// may contain references to type variables.
var enclosing = element.enclosingElement;
if ((element.isConstructor || element.isGenerativeConstructorBody) &&
- rtiNeed.classNeedsRti(enclosing)) {
+ rtiNeed.classNeedsRti(enclosing.declaration)) {
enclosing.typeVariables
.forEach((ResolutionTypeVariableType typeVariable) {
HParameterValue param =

Powered by Google App Engine
This is Rietveld 408576698