Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2849853002: Revert of Follow up from ARC conversion (Closed)

Created:
3 years, 7 months ago by sczs
Modified:
3 years, 7 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Follow up from ARC conversion (patchset #2 id:20001 of https://codereview.chromium.org/2851713002/ ) Reason for revert: Revert since its needed to revert https://codereview.chromium.org/2808873002 which broke the roller. Original issue's description: > Follow up from ARC conversion > > Addressing the comments raised in https://codereview.chromium.org/2808873002/ > > BUG=none > > Review-Url: https://codereview.chromium.org/2851713002 > Cr-Commit-Position: refs/heads/master@{#467951} > Committed: https://chromium.googlesource.com/chromium/src/+/6273712b527b4e13ec0d854fcd11e0b5e034eb2a TBR=stkhapugin@chromium.org,sdefresne@chromium.org,gambard@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Review-Url: https://codereview.chromium.org/2849853002 Cr-Commit-Position: refs/heads/master@{#467978} Committed: https://chromium.googlesource.com/chromium/src/+/8bd0a4b29e832247b34137c855f74967a85ed0bf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M ios/chrome/browser/ui/toolbar/toolbar_controller.mm View 2 chunks +4 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
sczs
Created Revert of Follow up from ARC conversion
3 years, 7 months ago (2017-04-28 13:31:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2849853002/1
3 years, 7 months ago (2017-04-28 13:32:15 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 13:32:59 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8bd0a4b29e832247b34137c855f7...

Powered by Google App Engine
This is Rietveld 408576698