Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2851713002: Follow up from ARC conversion (Closed)

Created:
3 years, 7 months ago by gambard
Modified:
3 years, 7 months ago
Reviewers:
stkhapugin, sdefresne
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Follow up from ARC conversion Addressing the comments raised in https://codereview.chromium.org/2808873002/ BUG=none Review-Url: https://codereview.chromium.org/2851713002 Cr-Commit-Position: refs/heads/master@{#467951} Committed: https://chromium.googlesource.com/chromium/src/+/6273712b527b4e13ec0d854fcd11e0b5e034eb2a

Patch Set 1 #

Patch Set 2 : add __block #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M ios/chrome/browser/ui/toolbar/toolbar_controller.mm View 2 chunks +4 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 22 (15 generated)
gambard
PTAL
3 years, 7 months ago (2017-04-28 08:17:27 UTC) #2
stkhapugin
lgtm
3 years, 7 months ago (2017-04-28 08:25:58 UTC) #4
commit-bot: I haz the power
This CL has an open dependency (Issue 2808873002 Patch 40001). Please resolve the dependency and ...
3 years, 7 months ago (2017-04-28 08:26:23 UTC) #6
sdefresne
lgtm
3 years, 7 months ago (2017-04-28 10:18:30 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2851713002/20001
3 years, 7 months ago (2017-04-28 10:18:46 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/6273712b527b4e13ec0d854fcd11e0b5e034eb2a
3 years, 7 months ago (2017-04-28 10:23:06 UTC) #21
sczs
3 years, 7 months ago (2017-04-28 13:31:24 UTC) #22
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2849853002/ by sczs@chromium.org.

The reason for reverting is: Revert since its needed to revert
https://codereview.chromium.org/2808873002 which broke the roller. .

Powered by Google App Engine
This is Rietveld 408576698