[ObjC ARC] Converts ios/chrome/browser/ui/toolbar:toolbar to ARC.

[ObjC ARC] Converts ios/chrome/browser/ui/toolbar:toolbar to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2808873002
Cr-Commit-Position: refs/heads/master@{#467947}
Committed: https://chromium.googlesource.com/chromium/src/+/8b6e180812e904c59ff0d72a3b2d4d8df7d7f37b

[Olivier, 2017-04-10 15:05:54]

The CQ bit was checked by olivierrobin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 15:06:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 15:13:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 15:13:02]

Dry run: Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Olivier, 2017-04-10 15:22:10]

[ObjC ARC] Converts ios/chrome/browser/ui/toolbar:toolbar to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

[Olivier, 2017-04-10 15:22:10]

The CQ bit was checked by olivierrobin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 15:22:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Olivier, 2017-04-10 15:38:44]

olivierrobin@chromium.org changed reviewers:
+ stkhapugin@chromium.org

[Olivier, 2017-04-10 15:38:45]

Please review, specially 
ios/chrome/browser/ui/toolbar/toolbar_tools_menu_button.mm

[stkhapugin, 2017-04-10 15:57:51]

lgtm with comment addressed.

https://codereview.chromium.org/2808873002/diff/20001/ios/chrome/browser/ui/t...
File ios/chrome/browser/ui/toolbar/toolbar_controller.mm (right):

https://codereview.chromium.org/2808873002/diff/20001/ios/chrome/browser/ui/t...
ios/chrome/browser/ui/toolbar/toolbar_controller.mm:208: ToolbarView* view_;
You should be able to synthesize the first three ivars and toolsPopupController_
and remove getters

https://codereview.chromium.org/2808873002/diff/20001/ios/chrome/browser/ui/t...
File ios/chrome/browser/ui/toolbar/toolbar_tools_menu_button.mm (right):

https://codereview.chromium.org/2808873002/diff/20001/ios/chrome/browser/ui/t...
ios/chrome/browser/ui/toolbar/toolbar_tools_menu_button.mm:55: CAShapeLayer*
pathLayers_[kNumberOfDots];
You should use NSArray of CAShapeLayer and cast to id when you store them, or
CFArray of CAShapeLayer. Your CL is correct in that it takes correct code and
keeps it correct, but it's not a great example of memory management to begin
with, and now it's just odd.

https://codereview.chromium.org/2808873002/diff/20001/ios/chrome/browser/ui/t...
ios/chrome/browser/ui/toolbar/toolbar_tools_menu_button.mm:215:
DCHECK(pathLayer);
This is an odd DCHECK, but you shouldn't need it with an NSArray.

[sdefresne, 2017-04-10 16:09:45]

sdefresne@chromium.org changed reviewers:
+ sdefresne@chromium.org

[sdefresne, 2017-04-10 16:09:45]

https://codereview.chromium.org/2808873002/diff/20001/ios/chrome/browser/ui/t...
File ios/chrome/browser/ui/toolbar/toolbar_tools_menu_button.mm (right):

https://codereview.chromium.org/2808873002/diff/20001/ios/chrome/browser/ui/t...
ios/chrome/browser/ui/toolbar/toolbar_tools_menu_button.mm:55: CAShapeLayer*
pathLayers_[kNumberOfDots];
On 2017/04/10 15:57:51, stkhapugin wrote:
> You should use NSArray of CAShapeLayer and cast to id when you store them, or
> CFArray of CAShapeLayer. Your CL is correct in that it takes correct code and
> keeps it correct, but it's not a great example of memory management to begin
> with, and now it's just odd. 

If using CFArray, please use base::ScopedCFTypeRef<CFArray> :-)

[commit-bot: I haz the power, 2017-04-10 16:41:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 16:41:41]

Dry run: This issue passed the CQ dry run.

[Olivier, 2017-04-11 08:18:50]

The CQ bit was checked by olivierrobin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 08:19:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 10:21:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 10:21:23]

Dry run: This issue passed the CQ dry run.

[gambard, 2017-04-27 15:34:25]

gambard@chromium.org changed reviewers:
+ gambard@chromium.org

[gambard, 2017-04-27 15:34:26]

sdefresne@: PTAL, can we land this as is?

[sdefresne, 2017-04-28 08:02:50]

lgtm as is to unblock ARC conversion while Olivier is OOO

Can you address the two comments in separate CLs?

https://codereview.chromium.org/2808873002/diff/40001/ios/chrome/browser/ui/t...
File ios/chrome/browser/ui/toolbar/toolbar_controller.mm (right):

https://codereview.chromium.org/2808873002/diff/40001/ios/chrome/browser/ui/t...
ios/chrome/browser/ui/toolbar/toolbar_controller.mm:80: #if
!defined(__has_feature) || !__has_feature(objc_arc)
This should move just below the "#include/#import" lines, before the "using ..."
lines.

https://codereview.chromium.org/2808873002/diff/40001/ios/chrome/browser/ui/t...
File ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm (right):

https://codereview.chromium.org/2808873002/diff/40001/ios/chrome/browser/ui/t...
ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm:859: // Reference
tempTHPC so the block retains it.
Followup: I always find the "[foo self]" strange; can we change this in a
followup CL to the following syntax (that should be semantically identical):

  __block TabHistoryPopupController* tempTHPC = _tabHistoryPopupController;
  [tempTHPC dismissAnimatedWithCompletion:^{
    ...
    // Reference tempTHPC so the block retains it.
    tempTHPC = nil;
  }];

[gambard, 2017-04-28 08:10:01]

The CQ bit was checked by gambard@chromium.org

[gambard, 2017-04-28 08:10:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
stkhapugin@chromium.org
Link to the patchset: https://codereview.chromium.org/2808873002/#ps40001
(title: "feedback")

[commit-bot: I haz the power, 2017-04-28 08:10:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 10:12:56]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493367001580520,
"parent_rev": "8f67705094cf459bb5eda915a47bc2780cc22868", "commit_rev":
"8b6e180812e904c59ff0d72a3b2d4d8df7d7f37b"}

[commit-bot: I haz the power, 2017-04-28 10:13:09]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/browser/ui/toolbar:toolbar to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/browser/ui/toolbar:toolbar to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2808873002
Cr-Commit-Position: refs/heads/master@{#467947}
Committed:
https://chromium.googlesource.com/chromium/src/+/8b6e180812e904c59ff0d72a3b2d...
==========

[commit-bot: I haz the power, 2017-04-28 10:13:10]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8b6e180812e904c59ff0d72a3b2d...

[sczs, 2017-04-28 13:27:50]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2852713002/ by sczs@chromium.org.

The reason for reverting is: Reverting since ios_chrome_smoke_egtests its
failing and it broke the autoroller.

https://uberchromegw.corp.google.com/i/internal.bling.main/builders/chromium-....