Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 2849813002: [LargeIconService] Allow overriding request URL by a field trial param (Closed)

Created:
3 years, 7 months ago by jkrcal
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

[LargeIconService] Allow overriding request URL by a field trial param This CL integrates last minute comments from product on the first experiment with fetch favicons on demand - for "Articles for you" on the New Tab Page. This CL further allows to override to request URL format using a field trial parameter so that operating that experiment is more flexible. BUG=705572 Review-Url: https://codereview.chromium.org/2839653002 Cr-Commit-Position: refs/heads/master@{#467051} (cherry picked from commit 99b05cd8620a446c0e84fefbf28e8db907b44bdc) Review-Url: https://codereview.chromium.org/2849813002 . Cr-Commit-Position: refs/branch-heads/3071@{#290} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/258b6493bff7901661c887ac3b08e5d2a83e2ad7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -12 lines) Patch
M components/favicon/core/large_icon_service.cc View 4 chunks +16 lines, -7 lines 0 comments Download
M components/favicon/core/large_icon_service_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
jkrcal
3 years, 7 months ago (2017-04-28 11:40:02 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
258b6493bff7901661c887ac3b08e5d2a83e2ad7.

Powered by Google App Engine
This is Rietveld 408576698